test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/vlan: rephrase a comment
@ 2019-04-19  9:54 Rami Rosen
  2019-04-23 20:18 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2019-04-19  9:54 UTC (permalink / raw)
  To: dts; +Cc: Rami Rosen

This trivial patch rephrases a comment in the 
vlan_send_packet() method of Vlan test module to 
better reflect its logic.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 tests/TestSuite_vlan.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py
index 4bf0ae8..3d13012 100644
--- a/tests/TestSuite_vlan.py
+++ b/tests/TestSuite_vlan.py
@@ -97,7 +97,7 @@ class TestVlan(TestCase):
 
     def vlan_send_packet(self, vid, num=1):
         """
-        Send $num of packet to portid, if vid is -1, it means send pakcage not include vlan id.
+        Send $num of packets to portid, if vid is -1, it means send a packet which does not include a vlan id.
         """
         # The package stream : testTxPort->dutRxPort->dutTxport->testRxPort
         port = self.tester.get_local_port(dutRxPortId)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/vlan: rephrase a comment
  2019-04-19  9:54 [dts] [PATCH] tests/vlan: rephrase a comment Rami Rosen
@ 2019-04-23 20:18 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-23 20:18 UTC (permalink / raw)
  To: Rami Rosen, dts

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Friday, April 19, 2019 2:54 AM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] tests/vlan: rephrase a comment
> 
> This trivial patch rephrases a comment in the
> vlan_send_packet() method of Vlan test module to better reflect its logic.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  tests/TestSuite_vlan.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py index
> 4bf0ae8..3d13012 100644
> --- a/tests/TestSuite_vlan.py
> +++ b/tests/TestSuite_vlan.py
> @@ -97,7 +97,7 @@ class TestVlan(TestCase):
> 
>      def vlan_send_packet(self, vid, num=1):
>          """
> -        Send $num of packet to portid, if vid is -1, it means send pakcage not
> include vlan id.
> +        Send $num of packets to portid, if vid is -1, it means send a packet
> which does not include a vlan id.
>          """
>          # The package stream : testTxPort->dutRxPort->dutTxport->testRxPort
>          port = self.tester.get_local_port(dutRxPortId)
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-23 20:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19  9:54 [dts] [PATCH] tests/vlan: rephrase a comment Rami Rosen
2019-04-23 20:18 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).