From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2D6C9A05D3 for ; Tue, 23 Apr 2019 22:34:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 259891B1FD; Tue, 23 Apr 2019 22:34:19 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 4D88B1B120 for ; Tue, 23 Apr 2019 22:34:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 13:34:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,387,1549958400"; d="scan'208";a="340120284" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2019 13:34:16 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 13:34:16 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 04:34:14 +0800 From: "Tu, Lijuan" To: Rami Rosen , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] tests/ipfrag: add method name in error message Thread-Index: AQHU+RMJlXgBupmd/0C55EhyyrA4QaZKNaTg Date: Tue, 23 Apr 2019 20:34:14 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA659B6@SHSMSX101.ccr.corp.intel.com> References: <1555940874-143226-1-git-send-email-ramirose@gmail.com> In-Reply-To: <1555940874-143226-1-git-send-email-ramirose@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODZmYTAwN2ItMDg1Yy00YzdkLWIwYjctN2Q3ODE4NDVkYzg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVitRaWdvYXhQUitHRzVZNE1TQVg2VndTVVZhTkJBSU52WWw3OXg1SFBZbmk3aEU3YzZwOWk3RTdKMHRsZWl2bCJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/ipfrag: add method name in error message X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen > Sent: Monday, April 22, 2019 6:48 AM > To: dts@dpdk.org > Cc: Rami Rosen > Subject: [dts] [PATCH] tests/ipfrag: add method name in error message >=20 > There is no way to know, when getting "failed on forward packet size" > error, whether it is from functional_check_ipv4() or functional_check_ipv= 6(). > This patch adds the method name when in these two method so we will be > able to track it. >=20 > Signed-off-by: Rami Rosen > --- > tests/TestSuite_ipfrag.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_ipfrag.py b/tests/TestSuite_ipfrag.py index > 9f47a2c..38a27e9 100644 > --- a/tests/TestSuite_ipfrag.py > +++ b/tests/TestSuite_ipfrag.py > @@ -170,7 +170,7 @@ l3fwd_ipv4_route_array[] =3D {\\\n" >=20 > # verify normal packet just by number, verify fragment packe= t by all > elements > pkts =3D self.tester.load_tcpdump_sniff_packets(inst) > - self.verify(len(pkts) =3D=3D expPkts, "Failed on forward pac= ket size " + > str(size)) > + self.verify(len(pkts) =3D=3D expPkts, "in > + functional_check_ipv4(): failed on forward packet size " + str(size)) > if flag =3D=3D 'frag': > idx =3D 1 > for pkt in pkts: > @@ -220,7 +220,7 @@ l3fwd_ipv4_route_array[] =3D {\\\n" >=20 > # verify normal packet just by number, verify fragment packe= t by all > elements > pkts =3D self.tester.load_tcpdump_sniff_packets(inst) > - self.verify(len(pkts) =3D=3D expPkts, "Failed on forward pac= ket size " + > str(size)) > + self.verify(len(pkts) =3D=3D expPkts, "In > + functional_check_ipv6(): failed on forward packet size " + str(size)) > if flag =3D=3D 'frag': > idx =3D 1 > for pkt in pkts: > -- > 1.8.3.1