Re: [dts] [PATCH] add new ipsec lib test scripts

["Tu, Lijuan" <lijuan.tu@intel.com>]

Could you please rework your patch, you patch is not based on DTS master branch, there is no file called tests/TestSuite_cryptodev_new_ipsec-gw.py in DTS

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xuyanjie
> Sent: Wednesday, April 17, 2019 2:50 AM
> To: dts@dpdk.org
> Cc: Xu, Yanjie <yanjie.xu@intel.com>
> Subject: [dts] [PATCH] add new ipsec lib test scripts
> 
> Signed-off-by: xuyanjie <yanjie.xu@intel.com>
> 
> diff --git a/tests/TestSuite_cryptodev_new_ipsec-gw.py
> b/tests/TestSuite_cryptodev_new_ipsec-gw.py
> index 5e348db..8062c4f 100644
> --- a/tests/TestSuite_cryptodev_new_ipsec-gw.py
> +++ b/tests/TestSuite_cryptodev_new_ipsec-gw.py
> @@ -66,14 +66,14 @@ class TestIPsecGW(TestCase):
>          self.logger.info("dut ports = " + str(self.dut_ports))
>          self.logger.info("ports_socket = " + str(self.ports_socket))
> 
> -        # Generally, testbed should has 4 ports NIC, like,
> +        # Generally, testbed should have 4 ports NIC, like,
>          # 03:00.0 03:00.1 03:00.2 03:00.3
>          # This test case will
>          # - physical link is 03:00.0 <-> 03:00.1 and 03:00.2 <-> 03:00.3
>          # - bind 03:00.0 and 03:00.2 to ipsec-secgw app
>          # - send test packet from 03:00.3
>          # - receive packet which forwarded by ipsec-secgw from 03:00.0
> -        # - configure port and peer in dts port.cfg
> +        # - http://git.dpdk.org/tools/dts/tree/conf/ports.cfg
[Lijuan] it do make sense to keep "configure port and peer in dts ports.cfg"
>          self.tx_port = self.tester.get_local_port(self.dut_ports[1])
>          self.rx_port = self.tester.get_local_port(self.dut_ports[0])
> 
> @@ -92,7 +92,7 @@ class TestIPsecGW(TestCase):
>              "config": None,
>              "P": "",
>              "p": "0x3",
> -            "f": "local_conf/ipsec_test.cfg",
> +            "f": "conf/new_lib_ipsec_test.cfg",
>              "u": "0x1"
>          }
> 
> @@ -180,7 +180,7 @@ class TestIPsecGW(TestCase):
>          result = self._execute_ipsec_gw_test(ipsec_gw_opt_str)
>          self.verify(result, "FAIL")
> 
> -    def test_qat_aes_128_ctr_ipv4_transport(self):
> +    def test_trs_qat_aes_128_ctr_ipv4(self):
>          if cc.is_test_skip(self):
>              return
> 
> --
> 2.7.4