From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 78F39A05D3 for ; Wed, 24 Apr 2019 18:31:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 374CC1B52A; Wed, 24 Apr 2019 18:31:39 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9711E1B520 for ; Wed, 24 Apr 2019 18:31:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 09:31:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,390,1549958400"; d="scan'208,217";a="164699930" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 24 Apr 2019 09:31:35 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 09:31:33 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 09:31:33 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.39]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 00:31:18 +0800 From: "Tu, Lijuan" To: Narala Praneeth Reddy , "dts@dpdk.org" CC: Faisal Masood , Vijaya Bhaskar Annayyolla Thread-Topic: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 Thread-Index: AQHU+ZTk2wZND4mZckCkHMTp/WBhDqZKJN+QgACDQACAANbA4A== Date: Wed, 24 Apr 2019 16:31:18 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA66033@SHSMSX101.ccr.corp.intel.com> References: <1555997061-21977-1-git-send-email-nareddy@marvell.com>, <8CE3E05A3F976642AAB0F4675D0AD20E0BA6575F@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjM1ZjQ1YTEtYmFhNS00ZDQ3LWJhMzctMWY5YjcwMWU1OWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSEk4NHhNVllVUkx2QlFIRHhRN215N3hhdDV0RVJ6RmRYUlRid3M2bmZMWXVzeUw4MnFEWEUwTkV4RnRraUdURCJ9 x-originating-ip: [10.239.127.40] Content-Type: multipart/alternative; boundary="_000_8CE3E05A3F976642AAB0F4675D0AD20E0BA66033SHSMSX101ccrcor_" MIME-Version: 1.0 Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --_000_8CE3E05A3F976642AAB0F4675D0AD20E0BA66033SHSMSX101ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Narala Praneeth Reddy [mailto:nareddy@marvell.com] Sent: Wednesday, April 24, 2019 4:27 AM To: Tu, Lijuan ; dts@dpdk.org Cc: Faisal Masood ; Vijaya Bhaskar Annayyolla Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pty= pe mapping is not supported for cavium_a063 Please find inline comments. ________________________________ From: Tu, Lijuan > Sent: Wednesday, April 24, 2019 1:10 AM To: Narala Praneeth Reddy; dts@dpdk.org Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specif= ic ptype mapping is not supported for cavium_a063 External Email ---------------------------------------------------------------------- > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > nareddy@marvell.com > Sent: Monday, April 22, 2019 10:24 PM > To: dts@dpdk.org > Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy > > > Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype > mapping is not supported for cavium_a063 > > From: Praneeth Reddy > > > Marking this test case as not applicable for cavium_a063 > > Signed-off-by: Praneeth Reddy > > --- > conf/test_case_checklist.json | 62 > +++++++++++++++++++++++++++++++++++++++- > tests/TestSuite_ptype_mapping.py | 2 +- > 2 files changed, 62 insertions(+), 2 deletions(-) > > diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.jso= n > index a1aa90b..decc946 100644 > --- a/conf/test_case_checklist.json > +++ b/conf/test_case_checklist.json > @@ -2200,5 +2200,65 @@ > "Bug ID": "", > "Comments": "the nic not support this case" > } > - ] > + ], > + "ptype_mapping_get": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_replace": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_reset": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_update": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ] > } > diff --git a/tests/TestSuite_ptype_mapping.py > b/tests/TestSuite_ptype_mapping.py > index 2771337..6e1fce1 100644 > --- a/tests/TestSuite_ptype_mapping.py > +++ b/tests/TestSuite_ptype_mapping.py > @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase): > Run at the start of each test suite. > """ > self.verify(self.nic in ['fortville_eagle', 'fortville_spirit', > - 'fortville_spirit_single', 'fortville_25g'], > + 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'], [Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything? [Praneeth] ptype_mapping test case get FAIL and mention NIC not supported w= henever complete DTS test suite ran for cavium_a063, inorder to make this t= est case as N/A, did following changes. 1. Added cavium_a063 to support list in TestS= uite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails a= nd moves to next step. 2. Later as I added all ptype_mapping test ca= ses in test_case_checklist.json, ptype_mapping test cases gets skip without= executing. Finally the result will be N/A instead of FAIL. Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063. [Lijuan] it's the right way to leverage item 2 to skip the test cases if yo= ur NIC not support them. Cavium_a063 does not support ptype mapping, so it = should not be added in the support list in TestSuite_ptype_mapping.py, that= 's why you get failure. If the cases don't be added in checklist, it will g= o to test cases which including the verify statement, otherwise it will ski= p the test cases. That's why you get what you want when you tried item 2, but it doesn't mean= we could use item 1 improperly. Remove item 1 and keep item 2 is suitable = for your purpose. > 'ptype mapping test can not support %s nic' % self.nic) > ports =3D self.dut.get_ports() > self.verify(len(ports) >=3D 1, "Insufficient ports for testing") > -- > 1.8.3.1 --_000_8CE3E05A3F976642AAB0F4675D0AD20E0BA66033SHSMSX101ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

 

&nbs= p;

From: Narala Praneeth Reddy [mailto:nareddy@marvell.com]
Sent: Wednesday, April 24, 2019 4:27 AM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Cc: Faisal Masood <fmasood@marvell.com>; Vijaya Bhaskar Annayy= olla <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd speci= fic ptype mapping is not supported for cavium_a063

 

P= lease find inline comments.

 <= /p>

From: Tu, Li= juan <lijuan.tu@intel.com>=
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.= org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd= specific ptype mapping is not supported for cavium_a063

 

External Email

----------------------------------------------------------------------


> -----Original Message-----
> From: dts [= mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>=
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pt= ype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <naredd= y@marvell.com>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  conf/test_case_checklist.json    | 62
> ++++++++++++++= +++++++++++++++= ++++++++++-
>  tests/TestSuite_ptype_mapping.py |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.= json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
>            = ;  "Bug ID": "",
>            = ;  "Comments": "the nic not support this case"
>          }
> -    ]
> +    ],
> +     "ptype_mapping_get": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_replace": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_reset": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_update": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +     ]
>  }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
>          Run at the start= of each test suite.
>          ""&quo= t;
>          self.verify(self= .nic in ['fortville_eagle', 'fortville_spirit',
> -            'f= ortville_spirit_single', 'fortville_25g'],
> +           = ; 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything?=

[Praneeth] = ptype_mapping test case get FAIL and mention NIC not supported whenever com= plete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes.
             &n= bsp;                1. Added cavium= _a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping = test cases doesn't get fails and moves to next step.
               =               2. Later as I added = all ptype_mapping test cases in test_case_checklist.json, ptype_mapping tes= t cases gets skip without executing. Finally the result will be N/A instead= of FAIL.
                &nbs= p;      Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063.=

[Lijuan] it’s the right w= ay to leverage item 2 to skip the test cases if your NIC not support them. = Cavium_a063 does not support ptype mapping, so it should not be added in the support list in TestSuite_ptype_mapping.py, that’= ;s why you get failure. If the cases don’t be added in checklist, it = will go to test cases which including the verify statement, otherwise it wi= ll skip the test cases.

That’s why you get what y= ou want when you tried item 2, but it doesn’t mean we could use item = 1 improperly. Remove item 1 and keep item 2 is suitable for your purpose.

>&nbs= p;             = 'ptype mapping test can not support %s nic' % self.nic)
>          ports =3D self.d= ut.get_ports()
>          self.verify(len(= ports) >=3D 1, "Insufficient ports for testing")
> --
> 1.8.3.1

--_000_8CE3E05A3F976642AAB0F4675D0AD20E0BA66033SHSMSX101ccrcor_--