test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/change_linkspeed precise judgment condition
@ 2019-04-24  1:57 zhuwenhui
  2019-04-24  5:39 ` Yao, BingX Y
  2019-05-06  1:29 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhuwenhui @ 2019-04-24  1:57 UTC (permalink / raw)
  To: dts; +Cc: zhuwenhui

Make the judgment conditions more precise

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_shutdown_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 9f3f03f..d31392d 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -334,7 +334,7 @@ class TestShutdownApi(TestCase):
             for port in self.ports:
                 out = self.tester.send_expect(
                     "ethtool %s" % self.tester.get_interface(self.tester.get_local_port(port)), "# ")
-                self.verify("Speed: %s" % config[0] in out,
+                self.verify("Speed: %sMb/s" % config[0] in out,
                             "Wrong speed reported by the self.tester.")
                 self.verify("Duplex: %s" % config[1] in out,
                             "Wrong link type reported by the self.tester.")
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/change_linkspeed precise judgment condition
  2019-04-24  1:57 [dts] [PATCH V1] tests/change_linkspeed precise judgment condition zhuwenhui
@ 2019-04-24  5:39 ` Yao, BingX Y
  2019-05-06  1:29 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Yao, BingX Y @ 2019-04-24  5:39 UTC (permalink / raw)
  To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX

Tested-by: Yao, BingX Y <bingx.y.yao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
Sent: Wednesday, April 24, 2019 9:58 AM
To: dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/change_linkspeed precise judgment condition

Make the judgment conditions more precise

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_shutdown_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 9f3f03f..d31392d 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -334,7 +334,7 @@ class TestShutdownApi(TestCase):
             for port in self.ports:
                 out = self.tester.send_expect(
                     "ethtool %s" % self.tester.get_interface(self.tester.get_local_port(port)), "# ")
-                self.verify("Speed: %s" % config[0] in out,
+                self.verify("Speed: %sMb/s" % config[0] in out,
                             "Wrong speed reported by the self.tester.")
                 self.verify("Duplex: %s" % config[1] in out,
                             "Wrong link type reported by the self.tester.")
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/change_linkspeed precise judgment condition
  2019-04-24  1:57 [dts] [PATCH V1] tests/change_linkspeed precise judgment condition zhuwenhui
  2019-04-24  5:39 ` Yao, BingX Y
@ 2019-05-06  1:29 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-05-06  1:29 UTC (permalink / raw)
  To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Wednesday, April 24, 2019 9:58 AM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/change_linkspeed precise judgment condition
> 
> Make the judgment conditions more precise
> 
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 9f3f03f..d31392d 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -334,7 +334,7 @@ class TestShutdownApi(TestCase):
>              for port in self.ports:
>                  out = self.tester.send_expect(
>                      "ethtool %s" %
> self.tester.get_interface(self.tester.get_local_port(port)), "# ")
> -                self.verify("Speed: %s" % config[0] in out,
> +                self.verify("Speed: %sMb/s" % config[0] in out,
>                              "Wrong speed reported by the self.tester.")
>                  self.verify("Duplex: %s" % config[1] in out,
>                              "Wrong link type reported by the self.tester.")
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-06  1:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24  1:57 [dts] [PATCH V1] tests/change_linkspeed precise judgment condition zhuwenhui
2019-04-24  5:39 ` Yao, BingX Y
2019-05-06  1:29 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).