From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1F68CA05D3 for ; Wed, 22 May 2019 07:54:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D90C514EC; Wed, 22 May 2019 07:54:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3EC9F3DC for ; Wed, 22 May 2019 07:54:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 22:54:25 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 21 May 2019 22:54:25 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 22:54:25 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 22:54:24 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by shsmsx102.ccr.corp.intel.com ([169.254.2.249]) with mapi id 14.03.0415.000; Wed, 22 May 2019 13:54:23 +0800 From: "Tu, Lijuan" To: "Peng, Yuan" , "dts@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dts] [PATCH]tests: correct parameters setting Thread-Index: AQHVDIAz4Ps2rJzzokmYPb0SdBeqOaZ2rJEQ Date: Wed, 22 May 2019 05:54:23 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA84035@SHSMSX101.ccr.corp.intel.com> References: <1558077510-53389-1-git-send-email-yuan.peng@intel.com> In-Reply-To: <1558077510-53389-1-git-send-email-yuan.peng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk5MTJkYjctNjBjNC00NjViLWI4NjMtOGUzMzA0YjFiMGFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWjRXaWsxZXhSTE5GSmNmRlVUbXlKRjhUUFZZaDc1eVcrdTF1SFhHME11a2htTkhydjRnXC91V3NwVEgza2hTOTYifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]tests: correct parameters setting X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan > Sent: Friday, May 17, 2019 3:19 PM > To: dts@dpdk.org > Cc: Peng, Yuan > Subject: [dts] [PATCH]tests: correct parameters setting >=20 > Correct proto and ttl settings. >=20 > Signed-off-by: Peng Yuan >=20 > diff --git a/tests/TestSuite_generic_flow_api.py > b/tests/TestSuite_generic_flow_api.py > index af27477..d11c97d 100644 > --- a/tests/TestSuite_generic_flow_api.py > +++ b/tests/TestSuite_generic_flow_api.py > @@ -61,9 +61,12 @@ MAX_VLAN =3D 4095 > MAX_QUEUE =3D 15 > MAX_VFQUEUE =3D 3 > MAX_PORT =3D 65535 > -MAX_PROTO =3D 133 > MAX_TTL =3D 255 > MAX_TOS =3D 255 > +TCP_PROTO =3D 6 > +UDP_PROTO =3D 17 > +SCTP_PROTO =3D 132 > +RESERVED_PROTO =3D 255 >=20 > class TestGeneric_flow_api(TestCase): >=20 > @@ -422,17 +425,14 @@ class TestGeneric_flow_api(TestCase): > pkt +=3D ", src=3D'%s'" % sip > if 'proto' in flows: > if "udp" in flows: > - proto =3D 17 > - extrapacket['proto'] =3D '17' > + proto =3D UDP_PROTO > elif "tcp" in flows: > - proto =3D 6 > - extrapacket['proto'] =3D '6' > + proto =3D TCP_PROTO > elif "sctp" in flows: > - proto =3D 132 > - extrapacket['proto'] =3D '132' > + proto =3D SCTP_PROTO > else: > - proto =3D self.generate_random_int(0, MAX_PROTO) > - extrapacket['proto'] =3D str(proto) > + proto =3D RESERVED_PROTO > + extrapacket['proto'] =3D str(proto) > flow_str +=3D "proto is %d " % proto > if 'sip' in flows or 'dip' in flows: > pkt +=3D ", proto=3D%d" % proto @@ -445,7 +445,7= @@ class > TestGeneric_flow_api(TestCase): > pkt +=3D ", tos=3D%d" % tos > extrapacket['tos'] =3D tos > if 'ttl' in flows: > - ttl =3D self.generate_random_int(0, MAX_TTL) > + ttl =3D self.generate_random_int(1, MAX_TTL) > flow_str +=3D "ttl is %d " % ttl > pkt +=3D ", ttl=3D%d" % ttl > extrapacket['ttl'] =3D ttl @@ -464,17 +464,14 @@ cla= ss > TestGeneric_flow_api(TestCase): > pkt +=3D "/IPv6(src=3D'%s', dst=3D'%s'" % (sip, dip) > if 'proto' in flows: > if "udp" in flows: > - proto =3D 17 > - extrapacket['proto'] =3D '17' > + proto =3D UDP_PROTO > elif "tcp" in flows: > - proto =3D 6 > - extrapacket['proto'] =3D '6' > + proto =3D TCP_PROTO > elif "sctp" in flows: > - proto =3D 132 > - extrapacket['proto'] =3D '132' > + proto =3D SCTP_PROTO > else: > - proto =3D self.generate_random_int(0, MAX_PROTO) > - extrapacket['proto'] =3D str(proto) > + proto =3D RESERVED_PROTO > + extrapacket['proto'] =3D str(proto) > flow_str +=3D "proto is %d " % proto > pkt +=3D ", nh=3D%d" % proto > if 'tc' in flows: > @@ -483,13 +480,13 @@ class TestGeneric_flow_api(TestCase): > pkt +=3D ", tc=3D%d" % tc > extrapacket['tos'] =3D str(tc) > if 'hop' in flows: > - hop =3D self.generate_random_int(0, 255) > + hop =3D self.generate_random_int(1, 255) > flow_str +=3D "hop is %d " % hop > pkt +=3D ", hlim=3D%d" % hop > extrapacket['ttl'] =3D str(hop) > if 'sctp' in flows: > - pkt +=3D ", nh=3D132" > - extrapacket['proto'] =3D '132' > + pkt +=3D ", nh=3D%d" % SCTP_PROTO > + extrapacket['proto'] =3D str(SCTP_PROTO) > pkt +=3D ")" > elif flow_type =3D=3D "tcp": > flow_str +=3D "/ tcp " > -- > 2.14.3