test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH] test_plans/qinq_filter: remove useless tx offload and	fix case description error
Date: Wed, 29 May 2019 02:13:13 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA864E4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1558410128-62949-1-git-send-email-xueqin.lin@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Tuesday, May 21, 2019 11:42 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] test_plans/qinq_filter: remove useless tx offload and
> fix case description error
> 
> From: "xueqin.lin" <xueqin.lin@intel.com>
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  test_plans/qinq_filter_test_plan.rst | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/test_plans/qinq_filter_test_plan.rst
> b/test_plans/qinq_filter_test_plan.rst
> index b8d7c34..fa995f3 100644
> --- a/test_plans/qinq_filter_test_plan.rst
> +++ b/test_plans/qinq_filter_test_plan.rst
> @@ -56,7 +56,7 @@ Testpmd configuration - 4 RX/TX queues per port
> 
>  #. set up testpmd with fortville NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 -- -i --rxq=4 --txq=4
> --tx-offloads=0x8fff  --disable-rss
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 -- -i --rxq=4
> + --txq=4 --disable-rss
> 
>  #. enable qinq::
> 
> @@ -89,7 +89,7 @@ Testpmd configuration - 4 RX/TX queues per port
> 
>  #. set up testpmd with fortville NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 -- -i --rxq=4 --txq=4
> --tx-offloads=0x8fff  --disable-rss
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 -- -i --rxq=4
> + --txq=4 --disable-rss
> 
>  #. enable qinq::
> 
> @@ -118,7 +118,7 @@ tester Configuration  #. send dual vlan packet with
> scapy, verify packets can filter to queues::
> 
> 
> sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=1)/Dot1Q(ty
> pe=0x8100,vlan=4093)/IP(src="192.168.0.1", dst="192.168.0.2")/Raw('x' * 20)],
> iface="eth17")
> -
> sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=2)/Dot1Q(ty
> pe=0x8100,vlan=4093)/IP(src="192.168.0.1", dst="192.168.0.2")/Raw('x' * 20)],
> iface="eth17")
> +
> + sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=2)/Dot1Q(
> + type=0x8100,vlan=4094)/IP(src="192.168.0.1",
> + dst="192.168.0.2")/Raw('x' * 20)], iface="eth17")
> 
>  Test Case 3: qinq packet filter to VF queues
> ============================================
> @@ -126,13 +126,13 @@ Test Case 3: qinq packet filter to VF queues
> 
>      linux cmdline: echo 2 > /sys/bus/pci/devices/0000:81:00.0/max_vfs
> 
> -#. bind igb_uio to vfs
> +#. bind igb_uio to vfs::
> 
>      linux cmdline: ./usertools/dpdk-devbind.py -b igb_uio 81:02.0 81:02.1
> 
>  #. set up testpmd with fortville PF NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 --socket-
> mem=1024,1024 --file-prefix=pf -w 81:00.0 -- -i --rxq=4 --txq=4 --tx-
> offloads=0x8fff
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4
> + --socket-mem=1024,1024 --file-prefix=pf -w 81:00.0 -- -i --rxq=4
> + --txq=4
> 
>  #. enable qinq::
> 
> @@ -158,7 +158,7 @@ Test Case 3: qinq packet filter to VF queues
> 
>  #. set up testpmd with fortville VF0 NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x3e0 -n 4 --socket-
> mem=1024,1024 --file-prefix=vf0 -w 81:02.0 -- -i --rxq=4 --txq=4 --rss-udp
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x3e0 -n 4
> + --socket-mem=1024,1024 --file-prefix=vf0 -w 81:02.0 -- -i --rxq=4
> + --txq=4
> 
>  #. PMD fwd only receive the packets::
> 
> @@ -172,9 +172,9 @@ Test Case 3: qinq packet filter to VF queues
> 
>      testpmd command: start
> 
> -#. set up testpmd with fortville VF0 NICs::
> +#. set up testpmd with fortville VF1 NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x7c0 -n 4 --socket-
> mem=1024,1024 --file-prefix=vf1 -w 81:02.0 -- -i --rxq=4 --txq=4 --rss-udp
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x7c0 -n 4
> + --socket-mem=1024,1024 --file-prefix=vf1 -w 81:02.1 -- -i --rxq=4
> + --txq=4
> 
>  #. PMD fwd only receive the packets::
> 
> @@ -193,7 +193,7 @@ tester Configuration
> 
>  #. send dual vlan packet with scapy, verify packets can filter to the
> corresponding PF and VF queues::
> 
> -
> sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=1)/Dot1Q(ty
> pe=0x8100,vlan=4094)/IP(src="192.168.0.1", dst="192.168.0.2")/Raw('x' * 20)],
> iface="eth17")
> +
> + sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=1)/Dot1Q(
> + type=0x8100,vlan=4093)/IP(src="192.168.0.1",
> + dst="192.168.0.2")/Raw('x' * 20)], iface="eth17")
> 
> sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=2)/Dot1Q(ty
> pe=0x8100,vlan=4094)/IP(src="192.168.0.1", dst="192.168.0.2")/Raw('x' * 20)],
> iface="eth17")
> 
> sendp([Ether(dst="3C:FD:FE:A3:A0:AE")/Dot1Q(type=0x8100,vlan=3)/Dot1Q(ty
> pe=0x8100,vlan=4094)/IP(src="192.168.0.1", dst="192.168.0.2")/Raw('x' * 20)],
> iface="eth17")
> 
> @@ -203,13 +203,13 @@ Test Case 4: qinq packet filter with different tpid
> 
>      linux cmdline: echo 2 > /sys/bus/pci/devices/0000:81:00.0/max_vfs
> 
> -#. bind igb_uio to vfs
> +#. bind igb_uio to vfs::
> 
>      linux cmdline: ./usertools/dpdk-devbind.py -b igb_uio 81:02.0 81:02.1
> 
>  #. set up testpmd with fortville PF NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4 --socket-
> mem=1024,1024 --file-prefix=pf -w 81:00.0 -- -i --rxq=4 --txq=4 --tx-
> offloads=0x8fff
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1f -n 4
> + --socket-mem=1024,1024 --file-prefix=pf -w 81:00.0 -- -i --rxq=4
> + --txq=4
> 
>  #. enable qinq::
> 
> @@ -239,7 +239,7 @@ Test Case 4: qinq packet filter with different tpid
> 
>  #. set up testpmd with fortville VF0 NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x3e0 -n 4 --socket-
> mem=1024,1024 --file-prefix=vf0 -w 81:02.0 -- -i --rxq=4 --txq=4 --rss-udp
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x3e0 -n 4
> + --socket-mem=1024,1024 --file-prefix=vf0 -w 81:02.0 -- -i --rxq=4
> + --txq=4
> 
>  #. PMD fwd only receive the packets::
> 
> @@ -253,9 +253,9 @@ Test Case 4: qinq packet filter with different tpid
> 
>      testpmd command: start
> 
> -#. set up testpmd with fortville VF0 NICs::
> +#. set up testpmd with fortville VF1 NICs::
> 
> -    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x7c0 -n 4 --socket-
> mem=1024,1024 --file-prefix=vf1 -w 81:02.0 -- -i --rxq=4 --txq=4 --rss-udp
> +    ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x7c0 -n 4
> + --socket-mem=1024,1024 --file-prefix=vf1 -w 81:02.1 -- -i --rxq=4
> + --txq=4
> 
>  #. PMD fwd only receive the packets::
> 
> @@ -272,8 +272,8 @@ Test Case 4: qinq packet filter with different tpid
> tester Configuration
>  --------------------
> 
> -#. send dual vlan packet with scapy, verify packets can filter to the
> corresponding VF queues::
> -7. send qinq packet with traffic generator, verify packets can filter to the
> corresponding VF queues.
> +#. send dual vlan packet with scapy, verify packets can filter to the
> corresponding VF queues.
> +#. send qinq packet with traffic generator, verify packets can filter to the
> corresponding VF queues.
> 
>  Note
>  ====================================================
> --
> 2.7.5


      reply	other threads:[~2019-05-29  2:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  3:42 Xueqin Lin
2019-05-29  2:13 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA864E4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).