test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
@ 2019-05-23 11:09 xiao,qimai
  2019-05-24  1:22 ` Li, WenjieX A
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: xiao,qimai @ 2019-05-23 11:09 UTC (permalink / raw)
  To: dts; +Cc: xiao,qimai

fix NameError: name 'ETHER_TYPES' is not defined on scapy 2.4.2

Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
---
 dep/Dot1BR.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dep/Dot1BR.py b/dep/Dot1BR.py
index f985f6a..114c19a 100644
--- a/dep/Dot1BR.py
+++ b/dep/Dot1BR.py
@@ -13,6 +13,7 @@ VBPE (virtual brige port extenstion)
 from scapy.packet import *
 from scapy.fields import *
 from scapy.layers.l2 import Ether
+from scapy.data import ETHER_TYPES
 
 class Dot1BR(Packet):
     name = "802.1BR"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
  2019-05-23 11:09 [dts] [PATCH V1] fix NameError on latest scapy 2.4.2 xiao,qimai
@ 2019-05-24  1:22 ` Li, WenjieX A
  2019-05-24  1:23 ` Li, WenjieX A
  2019-05-29  2:35 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Li, WenjieX A @ 2019-05-24  1:22 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX, Li, WenjieX A

Fix the issue of scapy 2.4: "NameError: name 'ETHER_TYPES' is not defined"
And it does not affect scapy 2.2/2.3. 

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com> 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xiao,qimai
> Sent: Thursday, May 23, 2019 7:10 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
> 
> fix NameError: name 'ETHER_TYPES' is not defined on scapy 2.4.2
> 
> Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
> ---
>  dep/Dot1BR.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dep/Dot1BR.py b/dep/Dot1BR.py index f985f6a..114c19a 100644
> --- a/dep/Dot1BR.py
> +++ b/dep/Dot1BR.py
> @@ -13,6 +13,7 @@ VBPE (virtual brige port extenstion)  from scapy.packet
> import *  from scapy.fields import *  from scapy.layers.l2 import Ether
> +from scapy.data import ETHER_TYPES
> 
>  class Dot1BR(Packet):
>      name = "802.1BR"
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
  2019-05-23 11:09 [dts] [PATCH V1] fix NameError on latest scapy 2.4.2 xiao,qimai
  2019-05-24  1:22 ` Li, WenjieX A
@ 2019-05-24  1:23 ` Li, WenjieX A
  2019-05-29  2:35 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Li, WenjieX A @ 2019-05-24  1:23 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Reviewed-by: Wenjie <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xiao,qimai
> Sent: Thursday, May 23, 2019 7:10 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
> 
> fix NameError: name 'ETHER_TYPES' is not defined on scapy 2.4.2
> 
> Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
> ---
>  dep/Dot1BR.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dep/Dot1BR.py b/dep/Dot1BR.py index f985f6a..114c19a 100644
> --- a/dep/Dot1BR.py
> +++ b/dep/Dot1BR.py
> @@ -13,6 +13,7 @@ VBPE (virtual brige port extenstion)  from scapy.packet
> import *  from scapy.fields import *  from scapy.layers.l2 import Ether
> +from scapy.data import ETHER_TYPES
> 
>  class Dot1BR(Packet):
>      name = "802.1BR"
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
  2019-05-23 11:09 [dts] [PATCH V1] fix NameError on latest scapy 2.4.2 xiao,qimai
  2019-05-24  1:22 ` Li, WenjieX A
  2019-05-24  1:23 ` Li, WenjieX A
@ 2019-05-29  2:35 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-05-29  2:35 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xiao,qimai
> Sent: Thursday, May 23, 2019 7:10 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] fix NameError on latest scapy 2.4.2
> 
> fix NameError: name 'ETHER_TYPES' is not defined on scapy 2.4.2
> 
> Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
> ---
>  dep/Dot1BR.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dep/Dot1BR.py b/dep/Dot1BR.py index f985f6a..114c19a 100644
> --- a/dep/Dot1BR.py
> +++ b/dep/Dot1BR.py
> @@ -13,6 +13,7 @@ VBPE (virtual brige port extenstion)  from scapy.packet
> import *  from scapy.fields import *  from scapy.layers.l2 import Ether
> +from scapy.data import ETHER_TYPES
> 
>  class Dot1BR(Packet):
>      name = "802.1BR"
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-29  2:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 11:09 [dts] [PATCH V1] fix NameError on latest scapy 2.4.2 xiao,qimai
2019-05-24  1:22 ` Li, WenjieX A
2019-05-24  1:23 ` Li, WenjieX A
2019-05-29  2:35 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).