From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 448AFA0096 for ; Wed, 5 Jun 2019 03:46:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3AC461B970; Wed, 5 Jun 2019 03:46:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9AFAC1B95D for ; Wed, 5 Jun 2019 03:46:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 18:46:39 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 04 Jun 2019 18:46:39 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 18:46:39 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 18:46:38 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.98]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 09:46:37 +0800 From: "Tu, Lijuan" To: "Wu, ChangqingX" , "dts@dpdk.org" CC: "Wu, ChangqingX" Thread-Topic: [dts] [PATCH V1] tests:change the methods of build example apps Thread-Index: AQHVFfo/Uajg1GoSiUarE8mVVSDB4aaMVQzw Date: Wed, 5 Jun 2019 01:46:36 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAA04A1@SHSMSX101.ccr.corp.intel.com> References: <1559119241-112216-1-git-send-email-changqingx.wu@intel.com> In-Reply-To: <1559119241-112216-1-git-send-email-changqingx.wu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTUyODdlMWQtMWUwMy00YmE2LTg4OTYtYjA5M2ExNTdhY2U2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYjlnRHZJZG9jTFRlak9JUWVcL292RGM2eTJRcjhrUHNHTllcL1k2cTlDVmFiY1JnVCs4MWZqcHFyMEJGbTRVQm9rIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests:change the methods of build example apps X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Wednesday, May 29, 2019 4:41 PM > To: dts@dpdk.org > Cc: Wu, ChangqingX > Subject: [dts] [PATCH V1] tests:change the methods of build example apps >=20 > Avoid finding not the RTE_SDK variable when compiling dpdk or > example/app, and modifying the compilation method. >=20 > Signed-off-by: changqingxwu > --- > tests/TestSuite_kni.py | 2 +- > tests/TestSuite_l3fwdacl.py | 2 +- > tests/TestSuite_loadbalancer.py | 2 +- > tests/TestSuite_ptpclient.py | 2 +- > tests/TestSuite_quota_watermark.py | 2 +- > tests/TestSuite_userspace_ethtool.py | 4 ++-- > 6 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index > 641d8b0..aa189f5 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -261,7 +261,7 @@ class TestKni(TestCase): > self.dut.send_expect("sed -i -e > 's/KNI_KMOD_ETHTOOL=3Dn$/KNI_KMOD_ETHTOOL=3Dy/' config/common_base", > "# ", 30) > self.dut.build_install_dpdk(self.target) >=20 > - out =3D self.dut.send_expect("make -C ./examples/kni/", "# ", 5) > + out =3D self.dut.build_dpdk_apps("./examples/kni/") > self.verify('Error' not in out, "Compilation failed") >=20 > self.extract_ports_cores_config(default_1_port_cores_config) > diff --git a/tests/TestSuite_l3fwdacl.py b/tests/TestSuite_l3fwdacl.py in= dex > 221417a..9d1c41e 100644 > --- a/tests/TestSuite_l3fwdacl.py > +++ b/tests/TestSuite_l3fwdacl.py > @@ -652,7 +652,7 @@ class TestL3fwdacl(TestCase): > TestL3fwdacl.default_rule["Port"] =3D self.dut_ports[1] >=20 > # compile l3fwd-acl > - out =3D self.dut.send_expect("make -C examples/l3fwd-acl", "# ") > + out =3D self.dut.build_dpdk_apps("examples/l3fwd-acl") > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > diff --git a/tests/TestSuite_loadbalancer.py > b/tests/TestSuite_loadbalancer.py index fdda939..9152c6c 100644 > --- a/tests/TestSuite_loadbalancer.py > +++ b/tests/TestSuite_loadbalancer.py > @@ -55,7 +55,7 @@ class TestLoadbalancer(TestCase): > "Flow4": [rx_port3, "1.0.3.1"], > } >=20 > - out =3D self.dut.send_expect("make -C examples/load_balancer", "= #") > + out =3D self.dut.build_dpdk_apps("examples/load_balancer") > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > diff --git a/tests/TestSuite_ptpclient.py b/tests/TestSuite_ptpclient.py = index > 27d0714..23590e4 100644 > --- a/tests/TestSuite_ptpclient.py > +++ b/tests/TestSuite_ptpclient.py > @@ -59,7 +59,7 @@ class TestPtpClient(TestCase): > self.dut.build_install_dpdk(self.target) >=20 > # build sample app > - out =3D self.dut.send_expect("make -C examples/ptpclient", "# ") > + out =3D self.dut.build_dpdk_apps("examples/ptpclient") > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > diff --git a/tests/TestSuite_quota_watermark.py > b/tests/TestSuite_quota_watermark.py > index aabb2fd..ad4ec3b 100644 > --- a/tests/TestSuite_quota_watermark.py > +++ b/tests/TestSuite_quota_watermark.py > @@ -112,7 +112,7 @@ class TestQuotaWatermark(TestCase, > IxiaPacketGenerator): > Builds the example app and checks for errors. > """ >=20 > - out =3D self.dut.send_expect("make -C examples/quota_watermark",= "# ") > + out =3D self.dut.build_dpdk_apps("examples/quota_watermark") > self.verify("Error" not in out and "No such file" not in out, > "Compilation error") >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index f8428ea..dba988b 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -58,7 +58,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > self.verify(len(self.ports) >=3D 2, "No ports found for " + self= .nic) >=20 > # build sample app > - out =3D self.dut.send_expect("make -C examples/ethtool", "# ") > + out =3D self.dut.build_dpdk_apps("examples/ethtool") > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > @@ -80,7 +80,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > pass >=20 > def build_ethtool(self): > - out =3D self.dut.send_expect("make -C examples/ethtool", "# ") > + out =3D self.dut.build_dpdk_apps("examples/ethtool") > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > -- > 2.17.2