From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CF263A0096 for ; Wed, 5 Jun 2019 05:02:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 708F61B94D; Wed, 5 Jun 2019 05:02:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 492651B945 for ; Wed, 5 Jun 2019 05:02:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 20:02:22 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 04 Jun 2019 20:02:22 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 20:02:21 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 20:02:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.6]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 11:02:19 +0800 From: "Tu, Lijuan" To: "Mei, JianweiX" , "dts@dpdk.org" CC: "Zhang, YanX A" Thread-Topic: [dts] [PATCH V1] update TestSuite_fdir reduce runtime Thread-Index: AQHVGeta0xzKh75ywECrspr8gGcOqKaMYkgQ Date: Wed, 5 Jun 2019 03:02:19 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAA0728@SHSMSX101.ccr.corp.intel.com> References: <1559552901-129712-1-git-send-email-jianweix.mei@intel.com> In-Reply-To: <1559552901-129712-1-git-send-email-jianweix.mei@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDU3OGY3MGItZjgxNS00ZjY2LTg1ZDktMzc0MzQxNjA3NDE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlpsMERoQTBIVlBuNjlPbnFqTVR1WXJsQ0dZN0J2XC96bFBQRHc3bUd4YmhuSmJaYmUzWFBEWFhYXC9DVmVBUlJTIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] update TestSuite_fdir reduce runtime X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei > Sent: Monday, June 3, 2019 5:08 PM > To: dts@dpdk.org > Cc: Zhang, YanX A > Subject: [dts] [PATCH V1] update TestSuite_fdir reduce runtime >=20 > From: "zhang,yan" >=20 > Optimize scapy open and close mode >=20 > Signed-off-by: zhang,yan > --- > tests/TestSuite_fdir.py | 36 +++++++++++++++++++++++++----------- > 1 file changed, 25 insertions(+), 11 deletions(-) >=20 > diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index > dac145b..14cc5c9 100644 > --- a/tests/TestSuite_fdir.py > +++ b/tests/TestSuite_fdir.py > @@ -63,17 +63,31 @@ class TestFdir(TestCase, IxiaPacketGenerator): > # Utility methods and other non-test code. > # >=20 > ################################################################ > ########### > + scapyCmds =3D [] > + > + def start_scapy(self): > + self.tester.scapy_foreground() > + self.scapyCmds.append('sys.path.append("./")') > + self.scapyCmds.append('from sctp import *') > + self.tester.send_expect('scapy', '>>> ', 10) > + sleep(2) > + > + def end_scapy(self): > + self.tester.send_expect("exit()", "#") > + > + def scapy_execute(self, timeout=3D60): > + for cmd in self.scapyCmds: > + self.tester.send_expect(cmd, ">>> ", timeout) > + > + self.scapyCmds =3D [] >=20 > def send_and_verify(self, condition, packet, queueid =3D -2): > """ > Send packages and verify behavior. > """ > - self.tester.scapy_foreground() > - self.tester.scapy_append('sys.path.append("./")') > - self.tester.scapy_append('from sctp import *') > - self.tester.scapy_append(packet) > + self.scapyCmds.append(packet) > self.dut.send_expect("start", "testpmd>") > - self.tester.scapy_execute() > + self.scapy_execute() > time.sleep(.5) > out =3D self.dut.get_session_output() > self.dut.send_expect("stop", "testpmd>") @@ -200,7 +214,7 @@ cla= ss > TestFdir(TestCase, IxiaPacketGenerator): > """ > Run before each test case. > """ > - pass > + self.start_scapy() >=20 > def fdir_set_rule(self): > """ > @@ -1165,7 +1179,7 @@ class TestFdir(TestCase, IxiaPacketGenerator): > dst_ip_temp =3D self.dst_ip > print "*src_ip_temp =3D " + src_ip_temp + "dst_ip_temp =3D " + > dst_ip_temp > flows.append('Ether(src=3D"52:00:00:00:00:00", > dst=3D"00:1B:21:8E:B2:30")/IP(src=3D"%s",dst=3D"%s")/UDP(sport=3D%d,dport= =3D%d)/Ra > w(load=3D"%s" + "X"*(%d - 42 - %d))' % (src_ip_temp, dst_ip_temp, 1021, 1= 021, > self.payload, frame_size, self.flexlength)) > - self.tester.scapy_append('wrpcap("test.pcap", [%s])' % string.jo= in(flows, > ',')) > + self.scapyCmds.append('wrpcap("/root/test.pcap", [%s])' % > + string.join(flows, ',')) >=20 > def perf_fdir_performance_2ports(self, test_type, num_rules, num_flo= ws): > """ > @@ -1176,10 +1190,10 @@ class TestFdir(TestCase, IxiaPacketGenerator): >=20 > tgen_input.append((self.tester.get_local_port(self.dut_ports[0])= , > self.tester.get_local_port(self.dut_ports[1]), > - "test.pcap")) > + "/root/test.pcap")) > tgen_input.append((self.tester.get_local_port(self.dut_ports[1])= , > self.tester.get_local_port(self.dut_ports[0]), > - "test.pcap")) > + "/root/test.pcap")) >=20 > print "self.ports_socket=3D%s" % (self.ports_socket) > # run testpmd for each core config @@ -1229,7 +1243,7 @@ class > TestFdir(TestCase, IxiaPacketGenerator): > self.logger.info("Running with frame size %d " % frame_s= ize) > self.fdir_perf_set_flows(num_flows, frame_size) >=20 > - self.tester.scapy_execute() > + self.scapy_execute() >=20 > """ > tgen_input.append([self.tester.get_local_port(self.dut_p= orts[0]), > @@ -1326,7 +1340,7 @@ class TestFdir(TestCase, IxiaPacketGenerator): > """ > Run after each test case. > """ > - pass > + self.end_scapy() >=20 > def tear_down_all(self): > """ > -- > 2.17.2