From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 35729A0096 for ; Wed, 5 Jun 2019 07:21:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04161559A; Wed, 5 Jun 2019 07:21:22 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9B2A32C15 for ; Wed, 5 Jun 2019 07:21:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 22:21:18 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 04 Jun 2019 22:21:18 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 22:21:17 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 22:21:17 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 13:21:16 +0800 From: "Tu, Lijuan" To: "Ma, LihongX" , "dts@dpdk.org" CC: "Ma, LihongX" Thread-Topic: [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap Thread-Index: AQHVGph4URNt9XKvrEqYv+Yxj0UEV6aMh6oA Date: Wed, 5 Jun 2019 05:21:15 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAA18DD@SHSMSX101.ccr.corp.intel.com> References: <1559600522-6156-1-git-send-email-lihongx.ma@intel.com> In-Reply-To: <1559600522-6156-1-git-send-email-lihongx.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIxMDg0NmQtZDdhMS00Y2VjLWI5YmMtOTU5NjlmNjJmZTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic3R2T1piNFMybFZYc0twQktBSDd5UEVBZGw5UE9EZEFJMmg1amQ2UUlXY3JcLzBNYmZBS0xOWUVcL2RCSVNlbXBWIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > Sent: Tuesday, June 4, 2019 6:22 AM > To: dts@dpdk.org > Cc: Ma, LihongX > Subject: [dts] [PATCH V1] framework/packet: remove the set of > conf.use_pcap >=20 > when set scapy conf.use_pcap=3DTrue, > in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method, it will= use the > libpcap to read packet. > in scapy 2.4, it will affect the sendp method, it will use module in pcap= y, so > you should upgrade pcapy to 0.11.3 if you want to set the conf.use_pcap t= o > True. > But after try, find it is not necessary to set the conf.use_pcap to True,= it no > effect to our cases. so remove the config in the file, that we no need to= do > anything after upgrade scapy. >=20 > Signed-off-by: lihong > --- > framework/packet.py | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/framework/packet.py b/framework/packet.py index > 4d872fd..97344cd 100755 > --- a/framework/packet.py > +++ b/framework/packet.py > @@ -45,7 +45,6 @@ from uuid import uuid4 from settings import FOLDERS >=20 > from scapy.config import conf [Lijuan] I think this line should also be removed. > -conf.use_pcap =3D True >=20 > import struct > from socket import AF_INET6 > -- > 2.7.4