From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "nareddy@marvell.com" <nareddy@marvell.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: "fmasood@marvell.com" <fmasood@marvell.com>,
"avijay@marvell.com" <avijay@marvell.com>
Subject: Re: [dts] [PATCH] link_flowctrl.py: mac control frame forward is not supported for cavium_a063
Date: Wed, 5 Jun 2019 05:39:57 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAA1A13@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1559633923-2122-1-git-send-email-nareddy@marvell.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Tuesday, June 4, 2019 3:39 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] link_flowctrl.py: mac control frame forward is not
> supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.com>
>
> Removed mac control frame paramater in testpmd for cavium_a063.
> Marked pause frame enabling test cases as not applicable for cavium_a063.
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
> tests/TestSuite_link_flowctrl.py | 34 +++++++++++++++++++++++++---------
> 1 file changed, 25 insertions(+), 9 deletions(-)
>
> diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
> index 0057b46..8961512 100644
> --- a/tests/TestSuite_link_flowctrl.py
> +++ b/tests/TestSuite_link_flowctrl.py
> @@ -149,7 +149,15 @@ class TestLinkFlowctrl(TestCase):
> tgenInput = []
> tgenInput.append((tester_tx_port, tester_rx_port, "test.pcap"))
>
> - self.dut.send_expect("set flow_ctrl rx %s tx %s 300 50 10 1
> mac_ctrl_frame_fwd %s autoneg %s %d " % (
> + if (self.nic in ["cavium_a063"]):
> + self.dut.send_expect("set flow_ctrl rx %s tx %s 300 50 10 1
> autoneg %s %d " % (
> + flow_control,
> + flow_control,
> + flow_control,
> + self.rx_port),
> + "testpmd> ")
> + else:
> + self.dut.send_expect("set flow_ctrl rx %s tx %s 300 50 10
> + 1 mac_ctrl_frame_fwd %s autoneg %s %d " % (
> flow_control,
> flow_control,
> pause_frame_fwd, @@ -250,10 +258,14 @@ class
> TestLinkFlowctrl(TestCase):
> PAUSE Frames must not be received by testpmd
> """
>
> - pause_frames = [self.build_pause_frame(0),
> - self.build_pause_frame(1),
> - self.build_pause_frame(2),
> - self.build_pause_frame(3)]
> + if (self.nic in ["cavium_a063"]):
> + pause_frames = [self.build_pause_frame(0),
> + self.build_pause_frame(1)]
> + else:
> + pause_frames = [self.build_pause_frame(0),
> + self.build_pause_frame(1),
> + self.build_pause_frame(2),
> + self.build_pause_frame(3)]
>
> for frame in pause_frames:
> port_stats = self.pause_frame_test(frame) @@ -265,10 +277,14 @@
> class TestLinkFlowctrl(TestCase):
> PAUSE Frames must not be received by testpmd
> """
>
> - pause_frames = [self.build_pause_frame(0),
> - self.build_pause_frame(1),
> - self.build_pause_frame(2),
> - self.build_pause_frame(3)]
> + if (self.nic in ["cavium_a063"]):
> + pause_frames = [self.build_pause_frame(0),
> + self.build_pause_frame(1)]
> + else:
> + pause_frames = [self.build_pause_frame(0),
> + self.build_pause_frame(1),
> + self.build_pause_frame(2),
> + self.build_pause_frame(3)]
>
> for frame in pause_frames:
> port_stats = self.pause_frame_test(frame, flow_control='on')
> --
> 1.8.3.1
prev parent reply other threads:[~2019-06-05 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 7:38 nareddy
2019-06-05 5:39 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAA1A13@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=avijay@marvell.com \
--cc=dts@dpdk.org \
--cc=fmasood@marvell.com \
--cc=nareddy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).