[dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap

[dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap

[lihong]

when set scapy conf.use_pcap=True,
in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method,
it will use the libpcap to read packet.
in scapy 2.4, it will affect the sendp method, it will use module
in pcapy, so you should upgrade pcapy to 0.11.3 if you want to set
the conf.use_pcap to True.
But after try, find it is not necessary to set the conf.use_pcap to
True, it no effect to our cases. so remove the config in the file,
that we no need to do anything after upgrade scapy.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/packet.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/framework/packet.py b/framework/packet.py
index 4d872fd..e0b98e3 100755
--- a/framework/packet.py
+++ b/framework/packet.py
@@ -44,12 +44,8 @@ import shlex        # separate command line for pipe
 from uuid import uuid4
 from settings import FOLDERS
 
-from scapy.config import conf
-conf.use_pcap = True
-
 import struct
 from socket import AF_INET6
-from scapy.all import conf
 from scapy.utils import wrpcap, rdpcap, hexstr
 from scapy.layers.inet import Ether, IP, TCP, UDP, ICMP
 from scapy.layers.inet6 import IPv6, IPv6ExtHdrRouting, IPv6ExtHdrFragment
-- 
2.7.4

Re: [dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, June 6, 2019 5:22 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V2] framework/packet: remove the set of
> conf.use_pcap
> 
> when set scapy conf.use_pcap=True,
> in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method, it will use the
> libpcap to read packet.
> in scapy 2.4, it will affect the sendp method, it will use module in pcapy, so
> you should upgrade pcapy to 0.11.3 if you want to set the conf.use_pcap to
> True.
> But after try, find it is not necessary to set the conf.use_pcap to True, it no
> effect to our cases. so remove the config in the file, that we no need to do
> anything after upgrade scapy.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/packet.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/framework/packet.py b/framework/packet.py index
> 4d872fd..e0b98e3 100755
> --- a/framework/packet.py
> +++ b/framework/packet.py
> @@ -44,12 +44,8 @@ import shlex        # separate command line for pipe
>  from uuid import uuid4
>  from settings import FOLDERS
> 
> -from scapy.config import conf
> -conf.use_pcap = True
> -
>  import struct
>  from socket import AF_INET6
> -from scapy.all import conf
>  from scapy.utils import wrpcap, rdpcap, hexstr  from scapy.layers.inet
> import Ether, IP, TCP, UDP, ICMP  from scapy.layers.inet6 import IPv6,
> IPv6ExtHdrRouting, IPv6ExtHdrFragment
> --
> 2.7.4