From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 399F4A00E6 for ; Wed, 12 Jun 2019 08:45:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 100C71D148; Wed, 12 Jun 2019 08:45:55 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E0D0A1D148 for ; Wed, 12 Jun 2019 08:45:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 23:45:52 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2019 23:45:52 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 23:45:52 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 23:45:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.188]) with mapi id 14.03.0415.000; Wed, 12 Jun 2019 14:45:50 +0800 From: "Tu, Lijuan" To: "Ma, LihongX" , "dts@dpdk.org" CC: "Ma, LihongX" Thread-Topic: [dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap Thread-Index: AQHVHCJu7miN3jWv6Ey6SD3KT7jHwqaXnKhA Date: Wed, 12 Jun 2019 06:45:49 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BABA761@SHSMSX101.ccr.corp.intel.com> References: <1559769731-7704-1-git-send-email-lihongx.ma@intel.com> In-Reply-To: <1559769731-7704-1-git-send-email-lihongx.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTBmZWUyM2QtNWFmNi00ZjU5LWJhYWYtNjRhOTJiZWMyYTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWFwvXC82Nm1nSkhTXC9Ib2JmVmxwMGZ4WVl4RFU2QVZsaFh3ZVlNRlpiZno0cHBBTTJCNThDaUFjRzRYM01CU3RXUSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > Sent: Thursday, June 6, 2019 5:22 AM > To: dts@dpdk.org > Cc: Ma, LihongX > Subject: [dts] [PATCH V2] framework/packet: remove the set of > conf.use_pcap >=20 > when set scapy conf.use_pcap=3DTrue, > in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method, it will= use the > libpcap to read packet. > in scapy 2.4, it will affect the sendp method, it will use module in pcap= y, so > you should upgrade pcapy to 0.11.3 if you want to set the conf.use_pcap t= o > True. > But after try, find it is not necessary to set the conf.use_pcap to True,= it no > effect to our cases. so remove the config in the file, that we no need to= do > anything after upgrade scapy. >=20 > Signed-off-by: lihong > --- > framework/packet.py | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/framework/packet.py b/framework/packet.py index > 4d872fd..e0b98e3 100755 > --- a/framework/packet.py > +++ b/framework/packet.py > @@ -44,12 +44,8 @@ import shlex # separate command line for pipe > from uuid import uuid4 > from settings import FOLDERS >=20 > -from scapy.config import conf > -conf.use_pcap =3D True > - > import struct > from socket import AF_INET6 > -from scapy.all import conf > from scapy.utils import wrpcap, rdpcap, hexstr from scapy.layers.inet > import Ether, IP, TCP, UDP, ICMP from scapy.layers.inet6 import IPv6, > IPv6ExtHdrRouting, IPv6ExtHdrFragment > -- > 2.7.4