test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] pmd: Support test in vector mode
Date: Thu, 13 Jun 2019 09:11:36 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BABD0B4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1560409623-9118-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Thursday, June 13, 2019 3:07 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] pmd: Support test in vector mode
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Vector mode processes frames in multiples of 4
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_pmd.py |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py index
> f5df8d5..bc3f6a7 100644
> --- a/tests/TestSuite_pmd.py
> +++ b/tests/TestSuite_pmd.py
> @@ -338,8 +338,8 @@ class TestPmd(TestCase,IxiaPacketGenerator):
>              l4csum_error = self.stop_and_get_l4csum_errors()
> 
>              # Check the l4 checksum errors reported for Rx port
> -            self.verify(1 == int(l4csum_error[1]),
> -                        "Wrong l4 checksum error count using rxfreet=%d (expected 1,
> reported %s)" %
> +            self.verify(4 == int(l4csum_error[1]),
> +                        "Wrong l4 checksum error count using rxfreet=%d
> + (expected 4, reported %s)" %
>                          (rxfreet_value, l4csum_error[1]))
> 
>              self.dut.send_expect("quit", "# ", 30) @@ -407,7 +407,7 @@ class
> TestPmd(TestCase,IxiaPacketGenerator):
> 
>          self.tester.scapy_foreground()
>          self.tester.scapy_append('nutmac="%s"' % mac)
> -        self.tester.scapy_append('sendp([Ether(dst=nutmac,
> src="52:00:00:00:00:00")/IP(len=%s)/UDP(%s)/Raw(load="\x50"*%s)],
> iface="%s")' % (
> +        self.tester.scapy_append('sendp([Ether(dst=nutmac,
> + src="52:00:00:00:00:00")/IP(len=%s)/UDP(%s)/Raw(load="\x50"*%s)],
> + iface="%s", count=4)' % (
>              load_size, checksum, padding, interface))
> 
>          out = self.tester.scapy_execute() @@ -429,11 +429,11 @@ class
> TestPmd(TestCase,IxiaPacketGenerator):
>          self.verify(self.pmdout.check_tx_bytes(p0tx_pkts, p1rx_pkts),
>                      "packet pass assert error, %d RX packets, %d TX packets" %
> (p1rx_pkts, p0tx_pkts))
> 
> -        self.verify(p1rx_bytes == frame_size - 4,
> -                    "packet pass assert error, expected %d RX bytes, actual %d" %
> (frame_size - 4, p1rx_bytes))
> +        self.verify(p1rx_bytes == (frame_size - 4)*4,
> +                    "packet pass assert error, expected %d RX bytes,
> + actual %d" % ((frame_size - 4)*4, p1rx_bytes))
> 
> -        self.verify(self.pmdout.check_tx_bytes(p0tx_bytes, frame_size - 4),
> -                    "packet pass assert error, expected %d TX bytes, actual %d" %
> (frame_size - 4, p0tx_bytes))
> +        self.verify(self.pmdout.check_tx_bytes(p0tx_bytes, (frame_size - 4)*4),
> +                    "packet pass assert error, expected %d TX bytes,
> + actual %d" % ((frame_size - 4)*4, p0tx_bytes))
> 
>          return out
> 
> --
> 1.7.9.5


      reply	other threads:[~2019-06-13  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  7:07 pvukkisala
2019-06-13  9:11 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BABD0B4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).