From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 19101A046B for ; Wed, 26 Jun 2019 09:01:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD56D5B3E; Wed, 26 Jun 2019 09:01:21 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D1ECB4F94 for ; Wed, 26 Jun 2019 09:01:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 00:01:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,418,1557212400"; d="scan'208";a="164255879" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 26 Jun 2019 00:01:15 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 00:01:15 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 26 Jun 2019 00:01:15 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 26 Jun 2019 00:01:14 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Wed, 26 Jun 2019 15:01:13 +0800 From: "Tu, Lijuan" To: "pvukkisala@marvell.com" , "dts@dpdk.org" CC: "avijay@marvell.com" , "fmasood@marvell.com" Thread-Topic: [dts] [PATCH] checksum_offload: Support this test in vector mode Thread-Index: AQHVIqIifMZ7ACVHCUqoPqrwpgW3wKatlDVg Date: Wed, 26 Jun 2019 07:01:12 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAC46D3@SHSMSX101.ccr.corp.intel.com> References: <1560510756-509-1-git-send-email-pvukkisala@marvell.com> In-Reply-To: <1560510756-509-1-git-send-email-pvukkisala@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjBjMzIwMzAtNTNkZC00OTExLWIxOWUtNjAxYmRmNWU0YjQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialFmdElwWnJ3TXFaRktJVVJiZGJHeG43SXAydDdwM2dSYk1pc3FMT3dicnBTZjNIZFRFTGh0TVplMGlvb1ZraSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] checksum_offload: Support this test in vector mode X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi Phanendra, Could you please rework the patch, applied failed , maybe because the code = baseline changed. Applying: checksum_offload: Support this test in vector mode error: patch failed: tests/TestSuite_checksum_offload.py:174 error: tests/TestSuite_checksum_offload.py: patch does not apply Patch failed at 0001 checksum_offload: Support this test in vector mode > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > pvukkisala@marvell.com > Sent: Friday, June 14, 2019 7:13 PM > To: dts@dpdk.org > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala > > Subject: [dts] [PATCH] checksum_offload: Support this test in vector mode >=20 > From: Phanendra Vukkisala >=20 > Send and sniff 4 packets to support vector mode cavium HW stops > calculating check sums upon receiving first incorrect checksum. So accept > unknown also as bad >=20 > Signed-off-by: Phanendra Vukkisala > --- > tests/TestSuite_checksum_offload.py | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index 6541ba5..d4021b9 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -118,7 +118,7 @@ class TestChecksumOffload(TestCase): > self.tester.scapy_foreground() >=20 > for packet_type in packets_sent.keys(): > - self.tester.scapy_append('sendp([%s], iface=3D"%s")' % > (packets_sent[packet_type], tx_interface)) > + self.tester.scapy_append('sendp([%s], iface=3D"%s", count=3D= 4)' > + % (packets_sent[packet_type], tx_interface)) > self.tester.scapy_execute() > out =3D self.dut.get_session_output(timeout=3D1) > lines =3D out.split("\r\n") > @@ -146,7 +146,10 @@ class TestChecksumOffload(TestCase): > self.verify("PKT_RX_L4_CKSUM_GOOD" in li= ne, "Packet Rx > L4 checksum valid-flags error!") > self.verify("PKT_RX_IP_CKSUM_GOOD" in li= ne, "Packet Rx > IP checksum valid-flags error!") > elif (flag =3D=3D 0): > - self.verify("PKT_RX_L4_CKSUM_BAD" in lin= e, "Packet Rx > L4 checksum valid-flags error!") > + if self.nic =3D=3D "cavium_a063": > + self.verify("PKT_RX_L4_CKSUM_BAD" in= line or > "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags > error!") > + else: > + self.verify("PKT_RX_L4_CKSUM_BAD" > + in line, "Packet Rx L4 checksum valid-flags error!") > self.verify("PKT_RX_IP_CKSUM_BAD" in lin= e, "Packet Rx IP > checksum valid-flags error!") >=20 > self.dut.send_expect("stop", "testpmd>") @@ -174,11 +177,11 @@ > class TestChecksumOffload(TestCase): >=20 > self.tester.send_expect("exit()", "#") >=20 > - inst =3D self.tester.tcpdump_sniff_packets(intf=3Drx_interface, > count=3Dlen(packets_sent), > + inst =3D self.tester.tcpdump_sniff_packets(intf=3Drx_interface, > + count=3Dlen(packets_sent)*4, > filters=3D[{'layer':'ether', 'config':{'src': sniff_src}= }]) >=20 > for packet_type in packets_sent.keys(): > - self.tester.scapy_append('sendp([%s], iface=3D"%s")' % > (packets_sent[packet_type], tx_interface)) > + self.tester.scapy_append('sendp([%s], iface=3D"%s", count=3D= 4)' > + % (packets_sent[packet_type], tx_interface)) >=20 > self.tester.scapy_execute() > p =3D self.tester.load_tcpdump_sniff_packets(inst) > @@ -186,7 +189,7 @@ class TestChecksumOffload(TestCase): > reslist =3D > [p[i].pktgen.pkt.sprintf("%IP.chksum%;%TCP.chksum%;%UDP.chksum%;%SCTP. > chksum%") for i in range(nr_packets)] > out =3D string.join(reslist, ",") > packets_received =3D out.split(',') > - self.verify(len(packets_sent) =3D=3D len(packets_received), "Une= xpected > Packets Drop") > + self.verify(len(packets_sent)*4 =3D=3D len(packets_received), > + "Unexpected Packets Drop") >=20 > for packet_received in packets_received: > ip_checksum, tcp_checksum, udp_checksum, sctp_checksum =3D > packet_received.split(';') > -- > 1.7.9.5