From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "thaq@marvell.com" <thaq@marvell.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "fmasood@marvell.com" <fmasood@marvell.com>,
"avijay@marvell.com" <avijay@marvell.com>
Subject: Re: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added condition check to selected "tpids" based on cards.
Date: Wed, 26 Jun 2019 07:08:14 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAC4FA4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1560759661-8842-1-git-send-email-thaq@marvell.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of thaq@marvell.com
> Sent: Monday, June 17, 2019 4:21 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Thanseerulhaq
> <thaq@marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added
> condition check to selected "tpids" based on cards.
>
> From: Thanseerulhaq <thaq@marvell.com>
>
> cavium_a063 cards supports only default tpids in rx mode so added
> conditon checks.
> Listing "test_vlan_qinq_tpid" & test_vlan_change_tpid testcase of
> vlan_ethertype_config as invalid for cavium_a063 cards.
>
> Signed-off-by: Thanseerulhaq <thaq@marvell.com>
> ---
> conf/test_case_checklist.json | 16 ++++++++++++++++
> tests/TestSuite_vlan_ethertype_config.py | 24 ++++++++++++++++++++----
> 2 files changed, 36 insertions(+), 4 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 7b46bc1..1c4dc6d 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2103,6 +2103,7 @@
> "fortville_spirit_single",
> "cavium_a034",
> "cavium_a011",
> + "cavium_a063"
> "fortville_25g"
> ],
> "Target": [
> @@ -2296,5 +2297,20 @@
> "Bug ID": "",
> "Comments": "the nic not support this case"
> }
> + ],
> + "vlan_change_tpid": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "cavium_a063"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "the nic not support this case"
> + }
> ]
> }
> diff --git a/tests/TestSuite_vlan_ethertype_config.py
> b/tests/TestSuite_vlan_ethertype_config.py
> index 684f68a..1cb1083 100644
> --- a/tests/TestSuite_vlan_ethertype_config.py
> +++ b/tests/TestSuite_vlan_ethertype_config.py
> @@ -198,7 +198,11 @@ class TestVlanEthertypeConfig(TestCase):
> self.dut.send_expect("vlan set strip off %s" %
> dutRxPortId, "testpmd> ", 20)
> rx_vlans = [1, random_vlan, MAX_VLAN]
> - tpids = [0x8100, 0xA100]
> + # caium_a063 card support only default '0x8100' tpid in rx mode
> + if self.nic == "cavium_a063":
> + tpids = [0x8100]
> + else:
> + tpids = [0x8100, 0xA100]
> for tpid in tpids:
> self.dut.send_expect("vlan set outer tpid 0x%x %s" %
> (tpid, dutRxPortId), "testpmd> ") @@ -226,7 +230,11
> @@ class TestVlanEthertypeConfig(TestCase):
> dutRxPortId, "testpmd> ", 20)
> self.dut.send_expect("start", "testpmd> ")
>
> - tpids = [0x8100, 0xA100]
> + # caium_a063 card support only default '0x8100' tpid in rx mode
> + if self.nic == "cavium_a063":
> + tpids = [0x8100]
> + else:
> + tpids = [0x8100, 0xA100]
> for tpid in tpids:
> self.dut.send_expect("vlan set outer tpid 0x%x %s" %
> (tpid, dutRxPortId), "testpmd> ") @@ -254,7 +262,11
> @@ class TestVlanEthertypeConfig(TestCase):
> "vlan set strip on %s" % dutRxPortId, "testpmd> ", 20)
> self.dut.send_expect("start", "testpmd> ", 20)
>
> - tpids = [0x8100, 0xA100]
> + # caium_a063 card support only default '0x8100' tpid in rx mode
> + if self.nic == "cavium_a063":
> + tpids = [0x8100]
> + else:
> + tpids = [0x8100, 0xA100]
> for tpid in tpids:
> self.dut.send_expect("vlan set outer tpid 0x%x %s" %
> (tpid, dutRxPortId), "testpmd> ") @@ -279,7 +291,11
> @@ class TestVlanEthertypeConfig(TestCase):
> dutRxPortId, "testpmd> ", 20)
> self.dut.send_expect("start", "testpmd> ")
>
> - tpids = [0x8100, 0xA100]
> + # caium_a063 card support only default '0x8100' tpid in rx mode
> + if self.nic == "cavium_a063":
> + tpids = [0x8100]
> + else:
> + tpids = [0x8100, 0xA100]
> for tpid in tpids:
> self.dut.send_expect("vlan set outer tpid 0x%x %s" %
> (tpid, dutTxPortId), "testpmd> ")
> --
> 1.8.3.1
prev parent reply other threads:[~2019-06-26 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:21 thaq
2019-06-26 7:08 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAC4FA4@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=avijay@marvell.com \
--cc=dts@dpdk.org \
--cc=fmasood@marvell.com \
--cc=thaq@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).