From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E3F63A046B for ; Wed, 26 Jun 2019 10:38:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCFC62BE6; Wed, 26 Jun 2019 10:38:05 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 823FA2BA7 for ; Wed, 26 Jun 2019 10:38:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 01:38:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,419,1557212400"; d="scan'208";a="360673703" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 26 Jun 2019 01:38:02 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 01:38:01 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 26 Jun 2019 01:38:01 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 26 Jun 2019 01:38:01 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.236]) with mapi id 14.03.0439.000; Wed, 26 Jun 2019 16:37:59 +0800 From: "Tu, Lijuan" To: "Wu, ChangqingX" , "dts@dpdk.org" CC: "Wu, ChangqingX" Thread-Topic: [dts] [PATCH V1] tests:remove ethtool from kni Thread-Index: AQHVJkdLGUrUSYdBF0ya0rvDyCobKaatqEvQ Date: Wed, 26 Jun 2019 08:37:58 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAC5319@SHSMSX101.ccr.corp.intel.com> References: <1560911823-9081-1-git-send-email-changqingx.wu@intel.com> In-Reply-To: <1560911823-9081-1-git-send-email-changqingx.wu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjYzYjNlNTAtNDAwNi00M2YyLTgxOTMtMzk0M2RkYzFhNzNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT005TkRvc0MrZzJzdWkwQ3dGbEV0NmNteHZqWVVvTXNrWVdWbWpEVFBlRXNSYlArUmhjQyswc1hMaGsrZng2VyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests:remove ethtool from kni X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Could you please rework your patch? Applying: tests:remove ethtool from kni error: patch failed: tests/TestSuite_kni.py:649 error: tests/TestSuite_kni.py: patch does not apply Patch failed at 0001 tests:remove ethtool from kni > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Wednesday, June 19, 2019 10:37 AM > To: dts@dpdk.org > Cc: Wu, ChangqingX > Subject: [dts] [PATCH V1] tests:remove ethtool from kni >=20 > remove test case ethtool from kni >=20 > Signed-off-by: changqingxwu > --- > tests/TestSuite_kni.py | 87 ------------------------------------------ > 1 file changed, 87 deletions(-) >=20 > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index > aa189f5..0d8aaf6 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -649,93 +649,6 @@ class TestKni(TestCase): > self.verify("%d packets captured" % len(packets_to_send) in = out, > "Wrong number of packets captured") >=20 > - def test_ethtool(self): > - """ > - Ethtool support KNI. > - """ > - > - # Ports and cores configuration set in set_up_all function > - # For each virtual interface perform the following operations > - for port in self.config['ports']: > - > - virtual_interface =3D self.virtual_interface_name(port) > - > - # Request settings > - out =3D self.dut.send_expect("ethtool %s" % virtual_interfac= e, > - "# ") > - self.verify("Settings for %s" % virtual_interface in out, > - "ethtool not supported") > - self.verify("Operation not supported" not in out, > - "ethtool not supported") > - > - # Request driver information > - out =3D self.dut.send_expect("ethtool -i %s" % virtual_inter= face, > - "# ") > - self.verify("driver: ixgbe" or "driver: igb" in out, > - "'ethtool -i' not supported") > - self.verify("Operation not supported" not in out, > - "'ethtool -i' not supported") > - > - # Request pause parameters > - with open("/usr/include/linux/ethtool.h","r") as ethtool_h: > - ethtool_contents =3D ethtool_h.read() > - GSET =3D "ETHTOOL_GLINKSETTINGS" > - SSET =3D "ETHTOOL_SLINKSETTINGS" > - if (GSET in ethtool_contents) and (SSET in ethtool_conte= nts): > - out =3D self.dut.send_expect("ethtool -a %s" % virtu= al_interface, > - "# ") > - self.verify("Pause parameters for %s" % virtual_inte= rface in out, > - "'ethtool -a' not supported") > - self.verify("Operation not supported" not in out, > - "ethtool '-a' not supported") > - > - # Request statistics > - out =3D self.dut.send_expect("ethtool -S %s" % virtual_inter= face, > - "# ") > - self.verify("NIC statistics" in out, > - "'ethtool -S' not supported") > - self.verify("Operation not supported" not in out, > - "ethtool '-S' not supported") > - > - # Request features status > - out =3D self.dut.send_expect("ethtool -k %s" % virtual_inter= face, "# ") > - self.verify(("Features for %s" % virtual_interface in out) o= r > - ("Offload parameters for %s" % > - virtual_interface in out), > - "'ethtool -k' not supported") > - self.verify("Operation not supported" not in out, > - "'ethtool -k' not supported") > - > - # Request ring parameters > - out =3D self.dut.send_expect("ethtool -g %s" % virtual_inter= face, > - "# ") > - self.verify("Ring parameters for %s" % virtual_interface in = out, > - "'ethtool -g' not supported") > - self.verify("Operation not supported" not in out, > - "'ethtool -g' not supported") > - > - # Request coalesce parameters. NOT SUPPORTED > - out =3D self.dut.send_expect("ethtool -c %s" % virtual_inter= face, > - "# ") > - self.verify("Operation not supported" in out, > - "'ethtool -c' seems to be supported. Check it.") > - > - # Request register dump > - out =3D self.dut.send_expect("ethtool -d %s" % virtual_inter= face, > - "# ") > - expectstring =3D "0x00000: CTRL.*0x00008: STATUS" > - self.verify(len(re.findall(expectstring, out , re.DOTALL)) >= 0, "'ethtool - > d' not supported") > - self.verify("Operation not supported" not in out, > - "'ethtool -d' not supported") > - > - # Request eeprom dump > - out =3D self.dut.send_expect("ethtool -e %s" % virtual_inter= face, > - "# ") > - self.verify("Offset" and "Values" in out, > - "'ethtool -e' not support") > - self.verify("Operation not supported" not in out, > - "'ethtool -e' not support") > - > def test_statistics(self): > """ > KNI Statistics test. > -- > 2.17.2