test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/TestSuite_ipgre.py: Modified ipgre-GRE_packet_chksum_offload testcase to Uncheck sctp chksum if nic-card is cavium_a063. Setting send packet count as 4 to support Vector mode.
@ 2019-06-18 14:36 thaq
  2019-06-26  8:41 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: thaq @ 2019-06-18 14:36 UTC (permalink / raw)
  To: dts; +Cc: fmasood, avijay, Thanseerulhaq

From: Thanseerulhaq <thaq@marvell.com>

Signed-off-by: Thanseerulhaq <thaq@marvell.com>
---
 tests/TestSuite_ipgre.py | 51 ++++++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 25 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index f188df0..de366b0 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -99,7 +99,7 @@ class TestIpgre(TestCase):
                 for layer in layer_configs.keys():
                     pkt.config_layer(layer, layer_configs[layer])
             inst = self.tester.tcpdump_sniff_packets(self.tester_iface, count=1, timeout=8)
-            pkt.send_pkt(tx_port=self.tester_iface)
+            pkt.send_pkt(tx_port=self.tester_iface, count = 4)
             out = self.dut.get_session_output(timeout=2)
             time.sleep(1)
             self.tester.load_tcpdump_sniff_packets(inst)
@@ -315,7 +315,8 @@ class TestIpgre(TestCase):
         self.dut.send_expect("port stop all", "testpmd>")
         self.dut.send_expect("csum set ip hw 0", "testpmd>")
         self.dut.send_expect("csum set udp hw 0", "testpmd>")
-        self.dut.send_expect("csum set sctp hw 0", "testpmd>")
+        if self.nic != "cavium_a063":
+            self.dut.send_expect("csum set sctp hw 0", "testpmd>")
         self.dut.send_expect("csum set outer-ip hw 0", "testpmd>")
         self.dut.send_expect("csum set tcp hw 0", "testpmd>")
         self.dut.send_expect("csum parse-tunnel on 0", "testpmd>")
@@ -407,29 +408,29 @@ class TestIpgre(TestCase):
                          'udp': {'chksum': 0xffff}}
         self.check_packet_transmission(pkt_types, config_layers)
         self.compare_checksum()
-    
-        # Send packet with wrong inner SCTP checksum and check forwarded packet SCTP checksum is correct
-        pkt_types = { "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT": ["PKT_TX_SCTP_CKSUM"]}
-        config_layers = {'ether': {'src': self.outer_mac_src, 
-                                   'dst': self.outer_mac_dst},
-                         'ipv4': {'proto': 'gre',
-                                  'src': self.outer_ip_src,
-                                  'dst': self.outer_ip_dst},
-                         'inner_ipv4':{'src':self.inner_ip_src,
-                                       'dst':self.inner_ip_dst},
-                         'sctp': {'src': 53,
-                                  'dst': 53}}
-        self.save_ref_packet(pkt_types, config_layers)
-        config_layers = {'ether': {'src': self.outer_mac_src, 
-                                   'dst': self.outer_mac_dst},
-                         'ipv4': {'proto': 'gre',
-                                  'src': self.outer_ip_src,
-                                  'dst': self.outer_ip_dst},
-                         'inner_ipv4':{'src':self.inner_ip_src,
-                                       'dst':self.inner_ip_dst},
-                         'sctp': {'chksum': 0x0}}
-        self.check_packet_transmission(pkt_types, config_layers)
-        self.compare_checksum()
+        if self.nic != "cavium_a063":
+            # Send packet with wrong inner SCTP checksum and check forwarded packet SCTP checksum is correct
+            pkt_types = { "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT": ["PKT_TX_SCTP_CKSUM"]}
+            config_layers = {'ether': {'src': self.outer_mac_src, 
+                                       'dst': self.outer_mac_dst},
+                             'ipv4': {'proto': 'gre',
+                                      'src': self.outer_ip_src,
+                                      'dst': self.outer_ip_dst},
+                             'inner_ipv4':{'src':self.inner_ip_src,
+                                           'dst':self.inner_ip_dst},
+                             'sctp': {'src': 53,
+                                      'dst': 53}}
+            self.save_ref_packet(pkt_types, config_layers)
+            config_layers = {'ether': {'src': self.outer_mac_src, 
+                                       'dst': self.outer_mac_dst},
+                             'ipv4': {'proto': 'gre',
+                                      'src': self.outer_ip_src,
+                                      'dst': self.outer_ip_dst},
+                             'inner_ipv4':{'src':self.inner_ip_src,
+                                           'dst':self.inner_ip_dst},
+                             'sctp': {'chksum': 0x0}}
+            self.check_packet_transmission(pkt_types, config_layers)
+            self.compare_checksum()
 
         self.dut.send_expect("quit", "#")
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/TestSuite_ipgre.py: Modified ipgre-GRE_packet_chksum_offload testcase to Uncheck sctp chksum if nic-card is cavium_a063. Setting send packet count as 4 to support Vector mode.
  2019-06-18 14:36 [dts] [PATCH] tests/TestSuite_ipgre.py: Modified ipgre-GRE_packet_chksum_offload testcase to Uncheck sctp chksum if nic-card is cavium_a063. Setting send packet count as 4 to support Vector mode thaq
@ 2019-06-26  8:41 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-06-26  8:41 UTC (permalink / raw)
  To: thaq, dts; +Cc: fmasood, avijay

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of thaq@marvell.com
> Sent: Tuesday, June 18, 2019 10:37 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Thanseerulhaq
> <thaq@marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_ipgre.py: Modified ipgre-
> GRE_packet_chksum_offload testcase to Uncheck sctp chksum if nic-card is
> cavium_a063. Setting send packet count as 4 to support Vector mode.
> 
> From: Thanseerulhaq <thaq@marvell.com>
> 
> Signed-off-by: Thanseerulhaq <thaq@marvell.com>
> ---
>  tests/TestSuite_ipgre.py | 51 ++++++++++++++++++++++++------------------------
>  1 file changed, 26 insertions(+), 25 deletions(-)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> f188df0..de366b0 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -99,7 +99,7 @@ class TestIpgre(TestCase):
>                  for layer in layer_configs.keys():
>                      pkt.config_layer(layer, layer_configs[layer])
>              inst = self.tester.tcpdump_sniff_packets(self.tester_iface, count=1,
> timeout=8)
> -            pkt.send_pkt(tx_port=self.tester_iface)
> +            pkt.send_pkt(tx_port=self.tester_iface, count = 4)
>              out = self.dut.get_session_output(timeout=2)
>              time.sleep(1)
>              self.tester.load_tcpdump_sniff_packets(inst)
> @@ -315,7 +315,8 @@ class TestIpgre(TestCase):
>          self.dut.send_expect("port stop all", "testpmd>")
>          self.dut.send_expect("csum set ip hw 0", "testpmd>")
>          self.dut.send_expect("csum set udp hw 0", "testpmd>")
> -        self.dut.send_expect("csum set sctp hw 0", "testpmd>")
> +        if self.nic != "cavium_a063":
> +            self.dut.send_expect("csum set sctp hw 0", "testpmd>")
>          self.dut.send_expect("csum set outer-ip hw 0", "testpmd>")
>          self.dut.send_expect("csum set tcp hw 0", "testpmd>")
>          self.dut.send_expect("csum parse-tunnel on 0", "testpmd>") @@ -
> 407,29 +408,29 @@ class TestIpgre(TestCase):
>                           'udp': {'chksum': 0xffff}}
>          self.check_packet_transmission(pkt_types, config_layers)
>          self.compare_checksum()
> -
> -        # Send packet with wrong inner SCTP checksum and check forwarded
> packet SCTP checksum is correct
> -        pkt_types = { "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["PKT_TX_SCTP_CKSUM"]}
> -        config_layers = {'ether': {'src': self.outer_mac_src,
> -                                   'dst': self.outer_mac_dst},
> -                         'ipv4': {'proto': 'gre',
> -                                  'src': self.outer_ip_src,
> -                                  'dst': self.outer_ip_dst},
> -                         'inner_ipv4':{'src':self.inner_ip_src,
> -                                       'dst':self.inner_ip_dst},
> -                         'sctp': {'src': 53,
> -                                  'dst': 53}}
> -        self.save_ref_packet(pkt_types, config_layers)
> -        config_layers = {'ether': {'src': self.outer_mac_src,
> -                                   'dst': self.outer_mac_dst},
> -                         'ipv4': {'proto': 'gre',
> -                                  'src': self.outer_ip_src,
> -                                  'dst': self.outer_ip_dst},
> -                         'inner_ipv4':{'src':self.inner_ip_src,
> -                                       'dst':self.inner_ip_dst},
> -                         'sctp': {'chksum': 0x0}}
> -        self.check_packet_transmission(pkt_types, config_layers)
> -        self.compare_checksum()
> +        if self.nic != "cavium_a063":
> +            # Send packet with wrong inner SCTP checksum and check forwarded
> packet SCTP checksum is correct
> +            pkt_types = { "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["PKT_TX_SCTP_CKSUM"]}
> +            config_layers = {'ether': {'src': self.outer_mac_src,
> +                                       'dst': self.outer_mac_dst},
> +                             'ipv4': {'proto': 'gre',
> +                                      'src': self.outer_ip_src,
> +                                      'dst': self.outer_ip_dst},
> +                             'inner_ipv4':{'src':self.inner_ip_src,
> +                                           'dst':self.inner_ip_dst},
> +                             'sctp': {'src': 53,
> +                                      'dst': 53}}
> +            self.save_ref_packet(pkt_types, config_layers)
> +            config_layers = {'ether': {'src': self.outer_mac_src,
> +                                       'dst': self.outer_mac_dst},
> +                             'ipv4': {'proto': 'gre',
> +                                      'src': self.outer_ip_src,
> +                                      'dst': self.outer_ip_dst},
> +                             'inner_ipv4':{'src':self.inner_ip_src,
> +                                           'dst':self.inner_ip_dst},
> +                             'sctp': {'chksum': 0x0}}
> +            self.check_packet_transmission(pkt_types, config_layers)
> +            self.compare_checksum()
> 
>          self.dut.send_expect("quit", "#")
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-26  8:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 14:36 [dts] [PATCH] tests/TestSuite_ipgre.py: Modified ipgre-GRE_packet_chksum_offload testcase to Uncheck sctp chksum if nic-card is cavium_a063. Setting send packet count as 4 to support Vector mode thaq
2019-06-26  8:41 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).