test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in	the verification condition.
Date: Wed, 3 Jul 2019 06:15:28 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BADA47A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1561619652-82208-1-git-send-email-shuaix.zhu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Thursday, June 27, 2019 3:14 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in
> the verification condition.
> 
> Since the current number of packets is 4, the verification conditions are not
> met, and the number of packets in the verification condition is modified.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_mac_filter.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
> index 9b896b4..a28bf9a 100644
> --- a/tests/TestSuite_mac_filter.py
> +++ b/tests/TestSuite_mac_filter.py
> @@ -109,7 +109,7 @@ class TestMacFilter(TestCase):
>          out = self.dut.get_session_output()
>          cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
>          # check the packet increase
> -        self.verify(int(cur_rxpkt) == self.frames_to_send,
> +        self.verify(int(cur_rxpkt)*self.frames_to_send ==
> + self.frames_to_send,
>                      "Packet has not been received on default address")
> 
>          # send one packet to a different MAC address @@ -127,7 +127,7 @@
> class TestMacFilter(TestCase):
>          out = self.dut.get_session_output()
>          cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
>          # check the packet increase
> -        self.verify(int(cur_rxpkt) == self.frames_to_send,
> +        self.verify(int(cur_rxpkt)*self.frames_to_send ==
> + self.frames_to_send,
>                      "Packet has not been received on a new MAC address that has
> been added to the port")
> 
>          # remove the fake MAC address
> --
> 2.17.2


      parent reply	other threads:[~2019-07-03  6:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  7:14 zhu,shuai
2019-06-27  7:10 ` Zhu, WenhuiX
2019-07-03  6:15 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BADA47A@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).