test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Yash Sharma <ysharma@marvell.com>, "dts@dpdk.org" <dts@dpdk.org>,
	"shshaikh@marvell.com" <shshaikh@marvell.com>
Cc: "psurana@marvell.com" <psurana@marvell.com>,
	"srane@marvell.com" <srane@marvell.com>
Subject: Re: [dts] [PATCH 1/1] Total Packet Length includes CRC(4 bytes) so no	need of adding extra 4 bytes for fastlinq Adapters.
Date: Wed, 3 Jul 2019 09:23:20 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BADA7AB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190627065024.30365-1-ysharma@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yash Sharma
> Sent: Thursday, June 27, 2019 2:50 PM
> To: dts@dpdk.org; shshaikh@marvell.com
> Cc: psurana@marvell.com; srane@marvell.com; yash
> <ysharma@marvell.com>
> Subject: [dts] [PATCH 1/1] Total Packet Length includes CRC(4 bytes) so no
> need of adding extra 4 bytes for fastlinq Adapters.
> 
> From: yash <ysharma@marvell.com>
> 
> Signed-off-by: yash <ysharma@marvell.com>
> ---
>  tests/TestSuite_jumboframes.py | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_jumboframes.py
> b/tests/TestSuite_jumboframes.py index cf4335a..1b5aab5 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -93,12 +93,18 @@ class TestJumboframes(TestCase):
>          rx_err -= rx_err_ori
> 
>          if received:
> -            self.verify(self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
> -                         and ( self.pmdout.check_tx_bytes(tx_bytes + 4, pktsize ))
> -                         and ((rx_bytes + 4) == pktsize),
> -                        "packet pass assert error")
> +           if self.nic.startswith('fastlinq'):
> +              self.verify(self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
> +                           and ( self.pmdout.check_tx_bytes(tx_bytes, pktsize ))
> +                           and (rx_bytes == pktsize),
> +                           "packet pass assert error")
> +           else:
> +              self.verify(self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
> +                           and ( self.pmdout.check_tx_bytes(tx_bytes + 4, pktsize ))
> +                           and ((rx_bytes + 4) == pktsize),
> +                           "packet pass assert error")
>          else:
> -            self.verify(rx_err == 1 or tx_pkts == 0, "packet drop assert error")
> +              self.verify(rx_err == 1 or tx_pkts == 0, "packet drop
> + assert error")
>          return out
> 
>      #
> --
> 1.8.3.1


  reply	other threads:[~2019-07-03  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  6:50 Yash Sharma
2019-07-03  9:23 ` Tu, Lijuan [this message]
2019-06-28  7:13 [dts] [PATCH 1/1] Patch adds preliminary settings to support Qlogic NICs Yash Sharma
2019-06-28  7:13 ` [dts] [PATCH 1/1] Total Packet Length includes CRC(4 bytes) so no need of adding extra 4 bytes for fastlinq Adapters Yash Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BADA7AB@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=psurana@marvell.com \
    --cc=shshaikh@marvell.com \
    --cc=srane@marvell.com \
    --cc=ysharma@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).