* [dts] [PATCH] tests/unit_tests_timer increase timeout
@ 2019-07-18 18:39 Thinh Tran
2019-07-19 8:49 ` Mo, YufengX
0 siblings, 1 reply; 8+ messages in thread
From: Thinh Tran @ 2019-07-18 18:39 UTC (permalink / raw)
To: dts; +Cc: thinhtr
- fix the TIMEOUT Failure for some systems have more than 16 cores
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
index 717dab8..f3bb02d 100644
--- a/tests/TestSuite_unit_tests_timer.py
+++ b/tests/TestSuite_unit_tests_timer.py
@@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
"""
cores = self.dut.get_core_list("all")
self.coremask = utils.create_mask(cores)
+ #
+ # change timeout base number of cores on the system
+ # default 60 secs
+ #
+ self.this_timeout = 60
+ if (len(cores) > 16) :
+ self.this_timeout = self.this_timeout * len(cores)/16
def set_up(self):
"""
@@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
+ out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
@@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
+ out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dts] [PATCH] tests/unit_tests_timer increase timeout
2019-07-18 18:39 [dts] [PATCH] tests/unit_tests_timer increase timeout Thinh Tran
@ 2019-07-19 8:49 ` Mo, YufengX
2019-07-19 12:59 ` [dts] [PATCH v2] " Thinh Tran
0 siblings, 1 reply; 8+ messages in thread
From: Mo, YufengX @ 2019-07-19 8:49 UTC (permalink / raw)
To: Thinh Tran, dts
Missing `self` in using this_timeout.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Thinh Tran
> Sent: Friday, July 19, 2019 2:39 AM
> To: dts@dpdk.org
> Cc: thinhtr@linux.vnet.ibm.com
> Subject: [dts] [PATCH] tests/unit_tests_timer increase timeout
>
>
> - fix the TIMEOUT Failure for some systems have more than 16 cores
>
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
> index 717dab8..f3bb02d 100644
> --- a/tests/TestSuite_unit_tests_timer.py
> +++ b/tests/TestSuite_unit_tests_timer.py
> @@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
> """
> cores = self.dut.get_core_list("all")
> self.coremask = utils.create_mask(cores)
> + #
> + # change timeout base number of cores on the system
> + # default 60 secs
> + #
> + self.this_timeout = 60
> + if (len(cores) > 16) :
> + self.this_timeout = self.this_timeout * len(cores)/16
>
> def set_up(self):
> """
> @@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> @@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dts] [PATCH v2] tests/unit_tests_timer increase timeout
2019-07-19 8:49 ` Mo, YufengX
@ 2019-07-19 12:59 ` Thinh Tran
2019-07-22 2:01 ` Mo, YufengX
0 siblings, 1 reply; 8+ messages in thread
From: Thinh Tran @ 2019-07-19 12:59 UTC (permalink / raw)
To: yufengx.mo; +Cc: dts, thinhtr
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
changes v1 -> v2:
- add missing self to this_timeout
tests/TestSuite_unit_tests_timer.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
index f3bb02d..365c5f6 100644
--- a/tests/TestSuite_unit_tests_timer.py
+++ b/tests/TestSuite_unit_tests_timer.py
@@ -78,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
+ out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
@@ -87,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
+ out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dts] [PATCH v2] tests/unit_tests_timer increase timeout
2019-07-19 12:59 ` [dts] [PATCH v2] " Thinh Tran
@ 2019-07-22 2:01 ` Mo, YufengX
2019-07-22 12:18 ` Thinh Tran
2019-07-22 13:15 ` [dts] [PATCH V3] " Thinh Tran
0 siblings, 2 replies; 8+ messages in thread
From: Mo, YufengX @ 2019-07-22 2:01 UTC (permalink / raw)
To: Thinh Tran; +Cc: dts
self.this_timeout is not defined. I think you haven't rebase your source code.
> -----Original Message-----
> From: Thinh Tran [mailto:thinhtr@linux.vnet.ibm.com]
> Sent: Friday, July 19, 2019 9:00 PM
> To: Mo, YufengX <yufengx.mo@intel.com>
> Cc: dts@dpdk.org; thinhtr@linux.vnet.ibm.com
> Subject: [dts][PATCH v2] tests/unit_tests_timer increase timeout
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> changes v1 -> v2:
> - add missing self to this_timeout
>
> tests/TestSuite_unit_tests_timer.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
> index f3bb02d..365c5f6 100644
> --- a/tests/TestSuite_unit_tests_timer.py
> +++ b/tests/TestSuite_unit_tests_timer.py
> @@ -78,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
> + out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> @@ -87,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
> + out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dts] [PATCH v2] tests/unit_tests_timer increase timeout
2019-07-22 2:01 ` Mo, YufengX
@ 2019-07-22 12:18 ` Thinh Tran
2019-07-22 13:15 ` [dts] [PATCH V3] " Thinh Tran
1 sibling, 0 replies; 8+ messages in thread
From: Thinh Tran @ 2019-07-22 12:18 UTC (permalink / raw)
To: Mo, YufengX; +Cc: dts
Sorry. v2 was on top off v1. will resend it shortly.
On 7/21/2019 9:01 PM, Mo, YufengX wrote:
> self.this_timeout is not defined. I think you haven't rebase your source code.
>
>
>> -----Original Message-----
>> From: Thinh Tran [mailto:thinhtr@linux.vnet.ibm.com]
>> Sent: Friday, July 19, 2019 9:00 PM
>> To: Mo, YufengX <yufengx.mo@intel.com>
>> Cc: dts@dpdk.org; thinhtr@linux.vnet.ibm.com
>> Subject: [dts][PATCH v2] tests/unit_tests_timer increase timeout
>>
>> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
>> ---
>> changes v1 -> v2:
>> - add missing self to this_timeout
>>
>> tests/TestSuite_unit_tests_timer.py | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
>> index f3bb02d..365c5f6 100644
>> --- a/tests/TestSuite_unit_tests_timer.py
>> +++ b/tests/TestSuite_unit_tests_timer.py
>> @@ -78,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
>> Run timer autotest.
>> """
>> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
>> - out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
>> + out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
>> self.dut.send_expect("quit", "# ")
>> self.verify("Test OK" in out, "Test failed")
>>
>> @@ -87,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
>> Run timer autotest.
>> """
>> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
>> - out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
>> + out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
>> self.dut.send_expect("quit", "# ")
>> self.verify("Test OK" in out, "Test failed")
>>
>> --
>> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [dts] [PATCH V3] tests/unit_tests_timer increase timeout
2019-07-22 2:01 ` Mo, YufengX
2019-07-22 12:18 ` Thinh Tran
@ 2019-07-22 13:15 ` Thinh Tran
2019-07-23 3:05 ` Mo, YufengX
2019-08-06 9:51 ` Tu, Lijuan
1 sibling, 2 replies; 8+ messages in thread
From: Thinh Tran @ 2019-07-22 13:15 UTC (permalink / raw)
To: yufengx.mo; +Cc: dts, thinhtr
- fix the TIMEOUT Failure for some systems have more than 16 cores
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
index 717dab8..365c5f6 100644
--- a/tests/TestSuite_unit_tests_timer.py
+++ b/tests/TestSuite_unit_tests_timer.py
@@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
"""
cores = self.dut.get_core_list("all")
self.coremask = utils.create_mask(cores)
+ #
+ # change timeout base number of cores on the system
+ # default 60 secs
+ #
+ self.this_timeout = 60
+ if (len(cores) > 16) :
+ self.this_timeout = self.this_timeout * len(cores)/16
def set_up(self):
"""
@@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
+ out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
@@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
Run timer autotest.
"""
self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
+ out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dts] [PATCH V3] tests/unit_tests_timer increase timeout
2019-07-22 13:15 ` [dts] [PATCH V3] " Thinh Tran
@ 2019-07-23 3:05 ` Mo, YufengX
2019-08-06 9:51 ` Tu, Lijuan
1 sibling, 0 replies; 8+ messages in thread
From: Mo, YufengX @ 2019-07-23 3:05 UTC (permalink / raw)
To: Thinh Tran; +Cc: dts
Signed-off-by: Mo, YufengX <yufengx.mo@intel.com>
> -----Original Message-----
> From: Thinh Tran [mailto:thinhtr@linux.vnet.ibm.com]
> Sent: Monday, July 22, 2019 9:16 PM
> To: Mo, YufengX <yufengx.mo@intel.com>
> Cc: dts@dpdk.org; thinhtr@linux.vnet.ibm.com
> Subject: [dts][PATCH V3] tests/unit_tests_timer increase timeout
>
> - fix the TIMEOUT Failure for some systems have more than 16 cores
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
> index 717dab8..365c5f6 100644
> --- a/tests/TestSuite_unit_tests_timer.py
> +++ b/tests/TestSuite_unit_tests_timer.py
> @@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
> """
> cores = self.dut.get_core_list("all")
> self.coremask = utils.create_mask(cores)
> + #
> + # change timeout base number of cores on the system
> + # default 60 secs
> + #
> + self.this_timeout = 60
> + if (len(cores) > 16) :
> + self.this_timeout = self.this_timeout * len(cores)/16
>
> def set_up(self):
> """
> @@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> @@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dts] [PATCH V3] tests/unit_tests_timer increase timeout
2019-07-22 13:15 ` [dts] [PATCH V3] " Thinh Tran
2019-07-23 3:05 ` Mo, YufengX
@ 2019-08-06 9:51 ` Tu, Lijuan
1 sibling, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2019-08-06 9:51 UTC (permalink / raw)
To: Thinh Tran, Mo, YufengX; +Cc: dts
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Thinh Tran
> Sent: Monday, July 22, 2019 9:16 PM
> To: Mo, YufengX <yufengx.mo@intel.com>
> Cc: dts@dpdk.org; thinhtr@linux.vnet.ibm.com
> Subject: [dts] [PATCH V3] tests/unit_tests_timer increase timeout
>
> - fix the TIMEOUT Failure for some systems have more than 16 cores
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_timer.py
> b/tests/TestSuite_unit_tests_timer.py
> index 717dab8..365c5f6 100644
> --- a/tests/TestSuite_unit_tests_timer.py
> +++ b/tests/TestSuite_unit_tests_timer.py
> @@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
> """
> cores = self.dut.get_core_list("all")
> self.coremask = utils.create_mask(cores)
> + #
> + # change timeout base number of cores on the system
> + # default 60 secs
> + #
> + self.this_timeout = 60
> + if (len(cores) > 16) :
> + self.this_timeout = self.this_timeout * len(cores)/16
>
> def set_up(self):
> """
> @@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target,
> self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_autotest", "RTE>>",
> self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> @@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
> Run timer autotest.
> """
> self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target,
> self.coremask), "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("timer_perf_autotest", "RTE>>",
> self.this_timeout)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-06 9:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 18:39 [dts] [PATCH] tests/unit_tests_timer increase timeout Thinh Tran
2019-07-19 8:49 ` Mo, YufengX
2019-07-19 12:59 ` [dts] [PATCH v2] " Thinh Tran
2019-07-22 2:01 ` Mo, YufengX
2019-07-22 12:18 ` Thinh Tran
2019-07-22 13:15 ` [dts] [PATCH V3] " Thinh Tran
2019-07-23 3:05 ` Mo, YufengX
2019-08-06 9:51 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).