test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Wu, ChangqingX" <changqingx.wu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Wu, ChangqingX" <changqingx.wu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results
Date: Wed, 7 Aug 2019 02:23:34 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAFEAE4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1562818503-49097-1-git-send-email-changqingx.wu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Thursday, July 11, 2019 12:15 PM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index c774552..dd8c9a6 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -316,9 +316,6 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          portsinfo = []
>          ori_drivers = []
> 
> -        if self.nic.startswith("fortville"):
> -            return
> -
>          for portid in range(len(self.ports)):
>              self.dut.send_expect("regs %d regs_%d.bin" % (portid, portid),
> "EthApp>")
>              portinfo = {'portid': portid, 'reg_file': 'regs_%d.bin' % portid} @@ -
> 338,7 +335,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
>              # get linux interface
>              intf = netdev.get_interface_name()
>              out = self.dut.send_expect("ethtool -d %s raw off file %s" % (intf,
> portinfo['reg_file']), "# ")
> -            self.verify(("LINKS" in out and "FCTRL" in out), "Failed to dump %s
> registers" % intf)
> +            self.verify(("register" in out and "CTRL" in out), "Failed
> + to dump %s registers" % intf)
> 
>          for index in range(len(self.ports)):
>              # bind to original driver
> --
> 2.17.2


      reply	other threads:[~2019-08-07  2:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  4:15 changqingxwu
2019-08-07  2:23 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAFEAE4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).