From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 109CBA00E6 for ; Wed, 7 Aug 2019 05:49:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9EF04C8F; Wed, 7 Aug 2019 05:49:13 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2FA322B8C for ; Wed, 7 Aug 2019 05:49:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 20:49:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,356,1559545200"; d="scan'208";a="179354311" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 06 Aug 2019 20:49:10 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 20:49:10 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 20:49:10 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Wed, 7 Aug 2019 11:49:08 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues Thread-Index: AQHVPGiBwWUwqGtJnEGmy8harHGhXqbvLUbA Date: Wed, 7 Aug 2019 03:49:07 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAFEDA2@SHSMSX101.ccr.corp.intel.com> References: <1563376870-42385-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1563376870-42385-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTRhZGNhZWQtZDZkYS00YTRhLTljOGItYzdhMTBjYjE3OTI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFp3d3hqanFKNVVCUmc0MmlRTXdVT1wvWnJOUmhUdERNMDFpeERXdHJLWlhySTFPRlZJbFNTY2JJWVBWbG5OSWUifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Wednesday, July 17, 2019 11:21 PM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues >=20 > 1. recover dpdk in test case 128_queues, instead of in tear_down. > 2. verify test result after recover and rebuild dpdk. > 3. change tab to space. >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_generic_filter.py | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) >=20 > diff --git a/tests/TestSuite_generic_filter.py > b/tests/TestSuite_generic_filter.py > index e7f480b..461db95 100644 > --- a/tests/TestSuite_generic_filter.py > +++ b/tests/TestSuite_generic_filter.py > @@ -704,9 +704,11 @@ class TestGeneric_filter(TestCase): >=20 > def test_128_queues(self): > # testpmd can't support assign queue to received packet, so can'= t test > + set_filter_flag =3D 1 > + packet_flag =3D 1 > if self.kdriver =3D=3D "ixgbe": > - self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128/' > drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) > - self.dut.build_install_dpdk(self.target) > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128/' > drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) > + self.dut.build_install_dpdk(self.target) > global valports > total_mbufs =3D self.request_mbufs(128) * len(valports) > self.pmdout.start_testpmd( > @@ -730,11 +732,14 @@ class TestGeneric_filter(TestCase): > if i =3D=3D 2: > out =3D self.dut.send_expect( > "set stat_qmap rx %s %s %s" % (valports[0], queu= e[i], (i + 1)), > "testpmd> ") > - self.verify('Invalid RX queue %s' % > - (queue[i]) in out, "set filters error") > + if 'Invalid RX queue %s' % (queue[i]) not in out: > + set_filter_flag =3D 0 > + break > out =3D self.dut.send_expect( > "5tuple_filter %s add dst_ip 2.2.2.5 src_ip 2.2.= 2.4 dst_port %s > src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x0 priority 3 queue %s " % > (valports[0], (i + 1), queue[i]), "testpmd> ") > - self.verify('error' in out, "set filters error") > + if 'error' not in out: > + set_filter_flag =3D 0 > + break > continue > else: > self.dut.send_expect("set stat_qmap rx %s %s %s" % @= @ - > 753,10 +758,14 @@ class TestGeneric_filter(TestCase): > scanner =3D re.compile(result_scanner, re.DOTALL) > m =3D scanner.search(out) > cur_pkt =3D m.group(1) > - self.verify( > - int(cur_pkt) =3D=3D frames_to_send, "packet pass ass= ert error") > - > + if int(cur_pkt) !=3D frames_to_send: > + packet_flag =3D 0 > + break > self.dut.send_expect("quit", "#") > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", > "# ",30) > + self.dut.build_install_dpdk(self.target) > + self.verify(set_filter_flag =3D=3D 1, "set filters error") > + self.verify(packet_flag =3D=3D 1, "packet pass assert error"= ) > else: > self.verify(False, "%s not support this test" % self.nic) >=20 > @@ -840,5 +849,6 @@ class TestGeneric_filter(TestCase): > Run after each test case. > """ > self.dut.kill_all() > - self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128/' > drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) > - self.dut.build_install_dpdk(self.target) > + > + def tear_down_all(self): > + pass > -- > 2.17.1