test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Yash Sharma <ysharma@marvell.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "shshaikh@marvell.com" <shshaikh@marvell.com>,
	"psurana@marvell.com" <psurana@marvell.com>,
	"srane@marvell.com" <srane@marvell.com>
Subject: Re: [dts] [PATCH 1/1] tests/TestSuite_vlan.py Set promisc off fastlinq adapters.
Date: Wed, 7 Aug 2019 06:33:24 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAFEEB8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190717104401.29176-1-ysharma@marvell.com>

Applied, thanks

> -----Original Message-----
> From: Yash Sharma [mailto:ysharma@marvell.com]
> Sent: Wednesday, July 17, 2019 6:44 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>
> Cc: shshaikh@marvell.com; psurana@marvell.com; srane@marvell.com; yash
> <ysharma@marvell.com>
> Subject: [PATCH 1/1] tests/TestSuite_vlan.py Set promisc off fastlinq
> adapters.
> 
> From: yash <ysharma@marvell.com>
> 
> Adding support for fastlinq adapters in Testsuite to set promisc off before
> starting the TestCase for Vlan Disable Test, Otherwise it accepts packets
> resulting in failure of Test.
> 
> Signed-off-by: yash <ysharma@marvell.com>
> ---
>  tests/TestSuite_vlan.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py index
> c7b4b62..86e7eb5 100644
> --- a/tests/TestSuite_vlan.py
> +++ b/tests/TestSuite_vlan.py
> @@ -75,7 +75,7 @@ class TestVlan(TestCase):
>          self.dut.send_expect("set verbose 1", "testpmd> ")
>          out = self.dut.send_expect("set fwd mac", "testpmd> ")
> 
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortpark_TLV", "fortville_25g", "hi1822"]:
> +        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortpark_TLV", "fortville_25g", "hi1822", "fastlinq_ql41000",
> "fastlinq_ql45000"]:
>              self.dut.send_expect("vlan set filter on %s" % dutRxPortId, "testpmd>
> ")
>              self.dut.send_expect("set promisc all off",  "testpmd> ")
> 
> --
> 1.8.3.1


      reply	other threads:[~2019-08-07  6:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 10:44 Yash Sharma
2019-08-07  6:33 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAFEEB8@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=psurana@marvell.com \
    --cc=shshaikh@marvell.com \
    --cc=srane@marvell.com \
    --cc=ysharma@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).