From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AA63A0613 for ; Wed, 28 Aug 2019 08:13:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D8EC1C1F1; Wed, 28 Aug 2019 08:13:37 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 13DC31C1ED for ; Wed, 28 Aug 2019 08:13:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 23:13:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="181927067" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2019 23:13:33 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 23:13:33 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Aug 2019 23:13:33 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Aug 2019 23:13:33 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 14:13:31 +0800 From: "Tu, Lijuan" To: "Peng, Yuan" , "dts@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dts] [PATCH v2]tests: remove a case from TestSuite_vlan.py Thread-Index: AQHVUn0oVdKKRIF/cUy4/ap/R9vayKcQKmlw Date: Wed, 28 Aug 2019 06:13:31 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB0689C@SHSMSX101.ccr.corp.intel.com> References: <1565772806-91639-1-git-send-email-yuan.peng@intel.com> In-Reply-To: <1565772806-91639-1-git-send-email-yuan.peng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmY5NGUyYWUtZjcxMi00ZGI1LWIwZGUtNjY0MzJlNTQxYmQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZWpqMjNIOHF3R3E2bGxkY1MrVjFEQ3Roc0swOG02MWFcLytaQkFmRnQrMlZvTlwvOFRIKzM2OXhPUXBFNVdcL2g1aiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2]tests: remove a case from TestSuite_vlan.py X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan > Sent: Wednesday, August 14, 2019 4:53 PM > To: dts@dpdk.org > Cc: Peng, Yuan > Subject: [dts] [PATCH v2]tests: remove a case from TestSuite_vlan.py >=20 > Remove a case from TestSuite_vlan.py according to the test plan. >=20 > Signed-off-by: Peng Yuan >=20 > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py index > 86e7eb5..9c58b0c 100644 > --- a/tests/TestSuite_vlan.py > +++ b/tests/TestSuite_vlan.py > @@ -73,14 +73,10 @@ class TestVlan(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop" % portMask) >=20 > self.dut.send_expect("set verbose 1", "testpmd> ") > - out =3D self.dut.send_expect("set fwd mac", "testpmd> ") > - > - if self.nic in ["fortville_eagle", "fortville_spirit", "fortvill= e_spirit_single", > "fortpark_TLV", "fortville_25g", "hi1822", "fastlinq_ql41000", > "fastlinq_ql45000"]: > - self.dut.send_expect("vlan set filter on %s" % dutRxPortId, = "testpmd> > ") > - self.dut.send_expect("set promisc all off", "testpmd> ") > - > + self.dut.send_expect("set fwd mac", "testpmd> ") > + self.dut.send_expect("set promisc all off", "testpmd> ") > + self.dut.send_expect("vlan set filter on %s" % dutRxPortId, > + "testpmd> ") > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, "tes= tpmd> ") > - self.verify('Set mac packet forwarding mode' in out, "set fwd rx= only > error") > self.vlan =3D 51 >=20 > if self.kdriver =3D=3D "fm10k": > @@ -128,9 +124,9 @@ class TestVlan(TestCase): > """ > pass >=20 > - def test_vlan_enable_receipt(self): > + def test_vlan_enable_receipt_strip_off(self): > """ > - Enable receipt of VLAN packets > + Enable receipt of VLAN packets and strip off > """ >=20 > if self.kdriver =3D=3D "fm10k": > @@ -140,6 +136,7 @@ class TestVlan(TestCase): > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, "te= stpmd> ") > self.dut.send_expect("start", "testpmd> ", 120) > out =3D self.dut.send_expect("show port info %s" % dutRxPortId, > "testpmd> ", 20) > + self.verify("strip off" in out, "Wrong strip:" + out) >=20 > self.vlan_send_packet(self.vlan) > out =3D self.get_tcpdump_package() @@ -157,8 +154,6 @@ class > TestVlan(TestCase): > """ > Disable receipt of VLAN packets > """ > - self.dut.send_expect("vlan set filter on %s" % dutRxPortId, "tes= tpmd> ") > - > self.dut.send_expect("rx_vlan rm %d %s" % (self.vlan, dutRxPortI= d), > "testpmd> ") > self.dut.send_expect("start", "testpmd> ", 120) > self.vlan_send_packet(self.vlan) @@ -166,11 +161,12 @@ class > TestVlan(TestCase): > out =3D self.get_tcpdump_package() > self.verify(len(out) =3D=3D 0, "Received unexpected packet, filt= er not > work!!!") > self.verify(self.vlan not in out, "Wrong vlan:" + str(out)) > + self.dut.send_expect("stop", "testpmd> ") >=20 > - out =3D self.dut.send_expect("stop", "testpmd> ") > - > - def test_vlan_strip_config_on(self): > - > + def test_vlan_enable_receipt_strip_on(self): > + """ > + Enable receipt of VLAN packets and strip on > + """ > self.dut.send_expect("vlan set strip on %s" % dutRxPortId, "test= pmd> ", > 20) > self.dut.send_expect("rx_vlan add %d %s" % (self.vlan, dutRxPort= Id), > "testpmd> ", 20) > out =3D self.dut.send_expect("show port info %s" % dutRxPortId, > "testpmd> ", 20) @@ -181,23 +177,7 @@ class TestVlan(TestCase): > out =3D self.get_tcpdump_package() > self.verify(len(out), "Forwarded vlan packet not received!!!") > self.verify(self.vlan not in out, "Wrong vlan:" + str(out)) > - out =3D self.dut.send_expect("stop", "testpmd> ", 120) > - > - def test_vlan_strip_config_off(self): > - > - if self.kdriver =3D=3D "fm10k": > - print utils.RED("fm10k not support this case\n") > - return > - self.dut.send_expect("vlan set strip off %s" % dutRxPortId, "tes= tpmd> ", > 20) > - self.dut.send_expect("rx_vlan add %d %s" % (self.vlan, dutRxPort= Id), > "testpmd> ", 20) > - out =3D self.dut.send_expect("show port info %s" % dutRxPortId, > "testpmd> ", 20) > - self.verify("strip off" in out, "Wrong strip:" + out) > - self.dut.send_expect("set nbport 2", "testpmd> ") > - self.dut.send_expect("start", "testpmd> ", 120) > - self.vlan_send_packet(self.vlan) > - out =3D self.get_tcpdump_package() > - self.verify(self.vlan in out, "Vlan not found:" + str(out)) > - out =3D self.dut.send_expect("stop", "testpmd> ", 120) > + self.dut.send_expect("stop", "testpmd> ", 120) >=20 > def test_vlan_enable_vlan_insertion(self): > """ > @@ -208,10 +188,6 @@ class TestVlan(TestCase): > netobj.add_vlan(vlan_id =3D self.vlan) > netobj.add_txvlan(vlan_id =3D self.vlan) >=20 > - port =3D self.tester.get_local_port(dutTxPortId) > - intf =3D self.tester.get_interface(port) > - > - self.dut.send_expect("set nbport 2", "testpmd> ") > self.dut.send_expect("stop", "testpmd> ") > self.dut.send_expect("port stop all", "testpmd> ") > self.dut.send_expect("tx_vlan set %s %d" % (dutTxPortId, self.vl= an), > "testpmd> ") > -- > 2.7.4