From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D64D0A0613 for ; Wed, 28 Aug 2019 12:46:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCA113256; Wed, 28 Aug 2019 12:46:50 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8BA842C4F for ; Wed, 28 Aug 2019 12:46:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 03:46:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="210125576" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 28 Aug 2019 03:46:47 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 03:46:47 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 03:46:47 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 18:46:45 +0800 From: "Tu, Lijuan" To: "Zhao, MeijuanX" , "dts@dpdk.org" CC: "Zhao, MeijuanX" Thread-Topic: [dts] [PATCH V1] tests: kernelpf_iavf fix some issues Thread-Index: AQHVU/yMqmweEWpl6E6xKKOB6zwA96cQc8BA Date: Wed, 28 Aug 2019 10:46:44 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB06D36@SHSMSX101.ccr.corp.intel.com> References: <20190816143343.26596-1-meijuanx.zhao@intel.com> In-Reply-To: <20190816143343.26596-1-meijuanx.zhao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJhNmU1OWMtOWExYi00ZjQ5LWIwZDQtZGM1NzE0MzM5MGYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOElKbW5iVmY2bDBkK012RmZSYkh4WmtWM1FFcVVaTjU3amF2RExvTlFRVnF5K0hsT1hMOW11Vk9NYlJGdU1MTyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests: kernelpf_iavf fix some issues X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhaomeijuan > Sent: Friday, August 16, 2019 10:34 PM > To: dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: [dts] [PATCH V1] tests: kernelpf_iavf fix some issues >=20 >=20 > *. change verify result > *. add wait time due to receive large pkt *. fix syntax error *. remove u= seless > setting for testpmd >=20 > Signed-off-by: zhaomeijuan > --- > tests/TestSuite_kernelpf_iavf.py | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/tests/TestSuite_kernelpf_iavf.py > b/tests/TestSuite_kernelpf_iavf.py > index 2e500fa..476b899 100644 > --- a/tests/TestSuite_kernelpf_iavf.py > +++ b/tests/TestSuite_kernelpf_iavf.py > @@ -245,7 +245,7 @@ class TestKernelpfIavf(TestCase): > stats =3D self.vm_testpmd.get_pmd_stats(0) > cap_tcp_num =3D re.findall('(\d+) packets', cap_packet) > nums =3D sum(map(int,cap_tcp_num)) > - self.verify(stats['TX-packets'] !=3D0 and nums > stats['TX-packe= ts'], 'vf send > packet num is not match') > + self.verify(stats['TX-packets'] !=3D0 and nums > 0, 'vf send > + packet num is not match') >=20 > def test_vf_mac_filter(self): > """ > @@ -521,22 +521,20 @@ class TestKernelpfIavf(TestCase): >=20 > self.vm_testpmd.start_testpmd("all") > self.vm_testpmd.execute_cmd("set fwd mac") > - self.vm_testpmd.execute_cmd("set promisc all off") > self.vm_testpmd.execute_cmd("start") > self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1, True) > self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False) > - self.tester.send_expect("ifconfig %s mtu %s" % (self.tester_intf= , > ETHER_STANDARD_MTU)) > + self.tester.send_expect("ifconfig %s mtu %s" % > + (self.tester_intf, ETHER_STANDARD_MTU), "#") >=20 > def test_vf_with_jumboframe(self): > self.tester.send_expect('ifconfig %s mtu %d' % (self.tester_intf= , > ETHER_JUMBO_FRAME_MTU), '#') > conf_pkt_len =3D 3000 > - self.vm_testpmd.start_testpmd("all", "--max-pkt-len=3D%d" % > conf_pkt_len) > + self.vm_testpmd.start_testpmd("all", "--max-pkt-len=3D%d > + --port-topology=3Dloop --tx-offloads=3D0x8000" % conf_pkt_len) > self.vm_testpmd.execute_cmd("set fwd mac") > - self.vm_testpmd.execute_cmd("set promisc all off") > self.vm_testpmd.execute_cmd("start") > self.jumboframes_send_packet(conf_pkt_len - 1, True) > self.jumboframes_send_packet(conf_pkt_len + 1, False) > - self.tester.send_expect("ifconfig %s mtu %d" % (self.tester_intf= , > ETHER_STANDARD_MTU)) > + self.tester.send_expect("ifconfig %s mtu %d" % > + (self.tester_intf, ETHER_STANDARD_MTU), "#") >=20 > def jumboframes_send_packet(self, pktsize, received=3DTrue): > """ > @@ -563,11 +561,11 @@ class TestKernelpfIavf(TestCase): > if received: > self.verify((rx_pkts =3D=3D 1) and (tx_pkts =3D=3D 1), "Pack= et forward assert > error") >=20 > - self.verify(rx_bytes =3D=3D pktsize, "Rx packet size should = be packet size") > + self.verify(rx_bytes + 4 =3D=3D pktsize, "Rx packet size sho= uld > + be packet size") >=20 > - self.verify(tx_bytes =3D=3D pktsize, "Tx packet size should = be packet size") > + self.verify(tx_bytes + 4 =3D=3D pktsize, "Tx packet size sho= uld > + be packet size") > else: > - self.verify(rx_err =3D=3D 1 or tx_pkts =3D=3D 0, "Packet dro= p assert error") > + self.verify(rx_err =3D=3D 1 or tx_pkts =3D=3D -1, "Packet dr= op > + assert error") >=20 > def test_vf_rss(self): > self.vm_testpmd.start_testpmd("all", "--txq=3D4 --rxq=3D4") @@ -= 714,7 > +712,7 @@ class TestKernelpfIavf(TestCase): > 'Raw(RandString(5214))], iface=3D"%s")' % (self.vf= _mac, > self.tester_intf) > self.tester.scapy_append(pkt) > self.tester.scapy_execute() > - time.sleep(2) > + time.sleep(5) > out =3D self.get_tcpdump_package() > self.verify_packet_segmentation(out) > self.vm_testpmd.execute_cmd("stop") > @@ -726,7 +724,7 @@ class TestKernelpfIavf(TestCase): > self.start_tcpdump(self.tester_intf) > self.tester.scapy_append(pkt) > self.tester.scapy_execute() > - time.sleep(2) > + time.sleep(5) > out =3D self.get_tcpdump_package() > self.verify_packet_segmentation(out, seg=3DFalse) >=20 > -- > 2.17.1