From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/tx_preparation: optimize script
Date: Wed, 4 Sep 2019 05:00:49 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB1BDF8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1566579803-48004-1-git-send-email-wenjiex.a.li@intel.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Saturday, August 24, 2019 1:03 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script
>
> move stop/quit testpmd into tear_down; otherwise, if one case is failed, the
> testpmd is still running, it will affect the following cases.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
> tests/TestSuite_tx_preparation.py | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index eea95c1..ba0aac7 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
> self.dut_testpmd.execute_cmd('start')
>
> self.send_packet_verify()
> - self.dut_testpmd.execute_cmd('stop')
> - self.dut_testpmd.quit()
>
> def test_tx_preparation_TSO(self):
> """
> @@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
> self.dut_testpmd.execute_cmd('start')
>
> self.send_packet_verify(1)
> - self.dut_testpmd.execute_cmd('stop')
> - self.dut_testpmd.quit()
> -
>
> def tear_down(self):
> """
> Run after each test case.
> - """
> - pass
> -
> + """
> + self.dut_testpmd.execute_cmd('stop')
> + self.dut_testpmd.quit()
>
> def tear_down_all(self):
> """
> --
> 2.17.1
prev parent reply other threads:[~2019-09-04 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 17:03 Wenjie Li
2019-08-23 8:24 ` Yao, BingX Y
2019-09-04 5:00 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB1BDF8@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=wenjiex.a.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).