test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"Wu, ChangqingX" <changqingx.wu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Mo, YufengX" <yufengx.mo@intel.com>
Subject: Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right	status
Date: Wed, 4 Sep 2019 05:04:46 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB1BE66@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1566797447-122407-2-git-send-email-yufengx.mo@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Monday, August 26, 2019 1:31 PM
> To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right
> status
> 
> 
> port start all action implies the race condition. The right way is to start top
> level bond port only, and let it propagate the start action to slave bonded
> ports and its the real nics.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_pmd_stacked_bonded.py
> b/tests/TestSuite_pmd_stacked_bonded.py
> index e1ce01a..de126b9 100644
> --- a/tests/TestSuite_pmd_stacked_bonded.py
> +++ b/tests/TestSuite_pmd_stacked_bonded.py
> @@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
>          cmds = [
>              ["port stop all", ''],
>              ["set portlist " + ",".join([str(port) for port in portList]), ''],
> -            ["port start all", ' ', 15]]
> +            # start top level bond port only, and let it propagate the start
> +            # action to slave bond ports and its the real nics.
> +            ["port start {}".format(master_bond_port), ' ', 15]
> +        ]
>          self.bond_inst.d_console(cmds)
>          # blank space command is used to skip LSC event to avoid core dumped
> issue
>          time.sleep(5)
> --
> 1.9.3


      parent reply	other threads:[~2019-09-04  5:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26  5:30 yufengmx
2019-08-26  5:30 ` yufengmx
2019-08-26  6:30   ` Wu, ChangqingX
2019-09-04  5:04   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB1BE66@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).