* Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status
2019-08-26 5:30 ` yufengmx
@ 2019-08-26 6:30 ` Wu, ChangqingX
2019-09-04 5:04 ` Tu, Lijuan
1 sibling, 0 replies; 4+ messages in thread
From: Wu, ChangqingX @ 2019-08-26 6:30 UTC (permalink / raw)
To: Mo, YufengX, dts
Tested-by: Wu, ChangqingX <changqingx.wu@intel.com>
-----Original Message-----
From: Mo, YufengX
Sent: Monday, August 26, 2019 1:31 PM
To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts][PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status
port start all action implies the race condition. The right way is to start top level bond port only, and let it propagate the start action to slave bonded ports and its the real nics.
Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/TestSuite_pmd_stacked_bonded.py b/tests/TestSuite_pmd_stacked_bonded.py
index e1ce01a..de126b9 100644
--- a/tests/TestSuite_pmd_stacked_bonded.py
+++ b/tests/TestSuite_pmd_stacked_bonded.py
@@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
cmds = [
["port stop all", ''],
["set portlist " + ",".join([str(port) for port in portList]), ''],
- ["port start all", ' ', 15]]
+ # start top level bond port only, and let it propagate the start
+ # action to slave bond ports and its the real nics.
+ ["port start {}".format(master_bond_port), ' ', 15]
+ ]
self.bond_inst.d_console(cmds)
# blank space command is used to skip LSC event to avoid core dumped issue
time.sleep(5)
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status
2019-08-26 5:30 ` yufengmx
2019-08-26 6:30 ` Wu, ChangqingX
@ 2019-09-04 5:04 ` Tu, Lijuan
1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-09-04 5:04 UTC (permalink / raw)
To: Mo, YufengX, Wu, ChangqingX, dts; +Cc: Mo, YufengX
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Monday, August 26, 2019 1:31 PM
> To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right
> status
>
>
> port start all action implies the race condition. The right way is to start top
> level bond port only, and let it propagate the start action to slave bonded
> ports and its the real nics.
>
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
> tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_pmd_stacked_bonded.py
> b/tests/TestSuite_pmd_stacked_bonded.py
> index e1ce01a..de126b9 100644
> --- a/tests/TestSuite_pmd_stacked_bonded.py
> +++ b/tests/TestSuite_pmd_stacked_bonded.py
> @@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
> cmds = [
> ["port stop all", ''],
> ["set portlist " + ",".join([str(port) for port in portList]), ''],
> - ["port start all", ' ', 15]]
> + # start top level bond port only, and let it propagate the start
> + # action to slave bond ports and its the real nics.
> + ["port start {}".format(master_bond_port), ' ', 15]
> + ]
> self.bond_inst.d_console(cmds)
> # blank space command is used to skip LSC event to avoid core dumped
> issue
> time.sleep(5)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread