test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] dual_vlan: Skip qinq on tests in random and synthetic	tests for cavium devices
Date: Wed, 18 Sep 2019 10:25:18 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB23D17@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1567746477-22414-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Friday, September 6, 2019 1:08 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] dual_vlan: Skip qinq on tests in random and synthetic
> tests for cavium devices
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Configuring QinQ ON is not supported now in cavium devices
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  conf/test_case_checklist.json |    4 +---
>  tests/TestSuite_dual_vlan.py  |    3 +++
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 71faa19..504a089 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -510,9 +510,7 @@
>                  "fortpark_TLV",
>                  "sagepond",
>                  "sageville",
> -                "cavium_a063",
> -                "cavium_a064",
> -		"carlsville"
> +                "carlsville"
>              ],
>              "Target": [
>                  "ALL"
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index f81fda1..9cb3879 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -205,6 +205,9 @@ class TestDualVlan(TestCase):
>          temp.append("on") if (caseDef & stripCase) != 0 else temp.append("off")
>          temp.append("on") if (caseDef & filterCase) != 0 else temp.append("off")
>          temp.append("on") if (caseDef & qinqCase) != 0 else temp.append("off")
> +        if (self.nic in ["cavium_a063", "cavium_a064"]) and temp[2] == "on":
> +            ## Skip QinQ for cavium devices as it is not supported.
> +            return
>          self.mode_config(strip=temp[0], filter=temp[1], qinq=temp[2])
> 
>          if (caseDef & txCase) != 0:
> --
> 1.7.9.5


      reply	other threads:[~2019-09-18 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  5:07 pvukkisala
2019-09-18 10:25 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB23D17@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).