test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
	"Ma, LihongX" <lihongx.ma@intel.com>
Cc: "Mo, YufengX" <yufengx.mo@intel.com>
Subject: Re: [dts] [PATCH V1 1/1] framework/pktgen_ixia: fix get wrong rate	percent
Date: Fri, 20 Sep 2019 06:21:58 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB24B53@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190912075457.19488-2-yufengx.mo@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Thursday, September 12, 2019 3:55 PM
> To: dts@dpdk.org; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1 1/1] framework/pktgen_ixia: fix get wrong rate
> percent
> 
> 
> fix get wrong rate percent, rate percent should get from stream config dict.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/pktgen_ixia.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py index
> 1e0675d..d324263 100644
> --- a/framework/pktgen_ixia.py
> +++ b/framework/pktgen_ixia.py
> @@ -1612,7 +1612,6 @@ class IxiaPacketGenerator(PacketGenerator):
>              tx_port = stream.get('tx_port')
>              rx_port = stream.get('rx_port')
>              pcap_file = stream.get('pcap_file')
> -            rate_percent = stream.get('rate')
>              # save port id list
>              if tx_port not in self._traffic_ports:
>                  self._traffic_ports.append(tx_port)
> @@ -1634,6 +1633,7 @@ class IxiaPacketGenerator(PacketGenerator):
>                  config['fields_config'] = self._vm_conf
>              # get stream rate percent
>              stream_config = options.get('stream_config')
> +            rate_percent = stream_config.get('rate')
>              # set port list input parameter of ixia class
>              ixia_option = [tx_port, rx_port, pcap_file, options]
>              port_config[tx_port].append(ixia_option)
> --
> 2.21.0


      parent reply	other threads:[~2019-09-20  6:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  7:54 [dts] [PATCH V1 0/1] " yufengmx
2019-09-12  7:54 ` [dts] [PATCH V1 1/1] " yufengmx
2019-09-16  2:45   ` Ma, LihongX
2019-09-20  6:21   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB24B53@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=yufengx.mo@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).