From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Peng, ZhihongX" <zhihongx.peng@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: "Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Peng@dpdk.org" <Peng@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to
Date: Fri, 20 Sep 2019 06:24:22 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB24BAF@SHSMSX101.ccr.corp.intel.com> (raw)
Comment inline
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, September 16, 2019 10:10 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase
> kill testpmd statement. check_packet_transmission func exiting abnormally
> willcause testpmd to not exit. The next test case continues to use untested
> testpmd, causing the test case to f...
>
> From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
>
> Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> ---
> tests/TestSuite_ipgre.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> d74ac05..d1db8df 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
> Run after each test case.
> Nothing to do.
> """
> + self.dut.kill_all()
> pass
[Lijuan] Please remove "pass"
>
> def tear_down_all(self):
> --
> 2.17.1
next reply other threads:[~2019-09-20 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 6:24 Tu, Lijuan [this message]
2019-09-23 1:49 ` Peng, ZhihongX
-- strict thread matches above, loose matches on Subject: below --
2019-09-16 8:31 Mo, YufengX
2019-09-16 8:35 ` Li, WenjieX A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB24BAF@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=Peng@dpdk.org \
--cc=dts@dpdk.org \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).