From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/tx_preparation:Modify the verification method.
Date: Mon, 21 Oct 2019 02:21:52 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB42EC3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1571043416-127726-1-git-send-email-shuaix.zhu@intel.com>
Please fix the warning, thanks
Applying: tests/tx_preparation:Modify the verification method.
.git/rebase-apply/patch:36: trailing whitespace.
self.verify("length %s" %LastLength in out and num == count,
warning: 1 line adds whitespace errors.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Monday, October 14, 2019 4:57 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/tx_preparation:Modify the verification
> method.
>
>
>
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
> tests/TestSuite_tx_preparation.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index 6d12724..cea3777 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -57,6 +57,7 @@ import random
> Normal_mtu = 1500
> Max_mtu = 9000
> TSO_value = 1460
> +count = 4
>
>
> class TestTX_preparation(TestCase):
> @@ -139,7 +140,7 @@ class TestTX_preparation(TestCase):
> for packet_type in pkts.keys():
> self.start_tcpdump(self.tester_intf)
> self.tester.scapy_append(
> - 'sendp([%s], iface="%s", count=4)' % (pkts[packet_type],
> self.tester_intf))
> + 'sendp([%s], iface="%s", count=%d)' % (pkts[packet_type],
> self.tester_intf, count))
> self.tester.scapy_execute()
> out = self.get_tcpdump_package()
> if packet_type == 'IPv6/cksum UDP':
> @@ -156,11 +157,11 @@ class TestTX_preparation(TestCase):
> segnum = LrgLength / TSO_value
> LastLength = LrgLength % TSO_value
> num = out.count('length %s' %TSO_value)
> - self.verify("length %s" %TSO_value in out and num == segnum,
> + self.verify("length %s" %TSO_value in out and num == segnum *
> count,
> "Failed to verify TSO correctness for large packets!!!")
> if LastLength != 0 :
> num = out.count('length %s' %LastLength)
> - self.verify("length %s" %LastLength in out and num == 1 ,
> + self.verify("length %s" %LastLength in out and num == count,
> "Failed to verify TSO correctness for large packets!!!")
>
>
> --
> 2.17.2
prev parent reply other threads:[~2019-10-21 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 8:56 zhu,shuai
2019-10-14 8:55 ` Zhu, WenhuiX
2019-10-21 2:21 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB42EC3@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=shuaix.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).