From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C0A6A3201 for ; Mon, 21 Oct 2019 04:21:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48802F3E; Mon, 21 Oct 2019 04:21:58 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 645CEF04 for ; Mon, 21 Oct 2019 04:21:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 19:21:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="222320289" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2019 19:21:55 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 19:21:55 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 19:21:54 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.225]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 10:21:53 +0800 From: "Tu, Lijuan" To: "Zhu, ShuaiX" , "dts@dpdk.org" CC: "Zhu, ShuaiX" Thread-Topic: [dts] [PATCH V1] tests/tx_preparation:Modify the verification method. Thread-Index: AQHVgmyjOu2u13m/CEGEzYy3l0a/2qdkZ7Kg Date: Mon, 21 Oct 2019 02:21:52 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB42EC3@SHSMSX101.ccr.corp.intel.com> References: <1571043416-127726-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1571043416-127726-1-git-send-email-shuaix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDg5YThmZjEtMjg5OS00OWRmLThlNTYtN2RkNDZkMTE3YmFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidE5ORXJrZFc5M0JkbkRcL0hmSk5jMnRuNnl2Y3lWWXRqVUpkbVVxTTdDZk0xclMxR0N6RU9BbkdSNjBSbUo0bUwifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/tx_preparation:Modify the verification method. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Please fix the warning, thanks Applying: tests/tx_preparation:Modify the verification method. .git/rebase-apply/patch:36: trailing whitespace. self.verify("length %s" %LastLength in out and num = =3D=3D count, warning: 1 line adds whitespace errors. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai > Sent: Monday, October 14, 2019 4:57 PM > To: dts@dpdk.org > Cc: Zhu, ShuaiX > Subject: [dts] [PATCH V1] tests/tx_preparation:Modify the verification > method. >=20 >=20 >=20 > Signed-off-by: zhu,shuai > --- > tests/TestSuite_tx_preparation.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_tx_preparation.py > b/tests/TestSuite_tx_preparation.py > index 6d12724..cea3777 100644 > --- a/tests/TestSuite_tx_preparation.py > +++ b/tests/TestSuite_tx_preparation.py > @@ -57,6 +57,7 @@ import random > Normal_mtu =3D 1500 > Max_mtu =3D 9000 > TSO_value =3D 1460 > +count =3D 4 >=20 >=20 > class TestTX_preparation(TestCase): > @@ -139,7 +140,7 @@ class TestTX_preparation(TestCase): > for packet_type in pkts.keys(): > self.start_tcpdump(self.tester_intf) > self.tester.scapy_append( > - 'sendp([%s], iface=3D"%s", count=3D4)' % (pkts[packet_ty= pe], > self.tester_intf)) > + 'sendp([%s], iface=3D"%s", count=3D%d)' % (pkts[packet_t= ype], > self.tester_intf, count)) > self.tester.scapy_execute() > out =3D self.get_tcpdump_package() > if packet_type =3D=3D 'IPv6/cksum UDP': > @@ -156,11 +157,11 @@ class TestTX_preparation(TestCase): > segnum =3D LrgLength / TSO_value > LastLength =3D LrgLength % TSO_value > num =3D out.count('length %s' %TSO_value) > - self.verify("length %s" %TSO_value in out and num = =3D=3D segnum, > + self.verify("length %s" %TSO_value in out and num = =3D=3D segnum * > count, > "Failed to verify TSO correctness for large pack= ets!!!") > if LastLength !=3D 0 : > num =3D out.count('length %s' %LastLength) > - self.verify("length %s" %LastLength in out and n= um =3D=3D 1 , > + self.verify("length %s" %LastLength in out and n= um =3D=3D count, > "Failed to verify TSO correctness for large pack= ets!!!") >=20 >=20 > -- > 2.17.2