From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
Date: Tue, 22 Oct 2019 09:11:20 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB44F46@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1571297390-82545-1-git-send-email-qimaix.xiao@intel.com>
Applied,thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 3:30 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
>
> fix save pcapfile method to new api
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> tests/bonding.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/bonding.py b/tests/bonding.py index fb2a69e..6c136a3
> 100644
> --- a/tests/bonding.py
> +++ b/tests/bonding.py
> @@ -36,7 +36,7 @@ import struct
> import socket
> from socket import htonl
>
> -from packet import Packet
> +from packet import Packet, TMP_PATH
> from scapy.sendrecv import sendp
> from scapy.utils import wrpcap
>
> @@ -181,14 +181,14 @@ class PmdBonding(object):
> # create packet
> streams = []
> # keep a copy of pcap for debug
> - savePath = os.sep.join([self.target_source,
> + savePath = os.sep.join([TMP_PATH,
> "pkt_{0}.pcap".format(pkt_name)])
> pkt_type = pkt_config.get('type')
> pkt_layers = pkt_config.get('pkt_layers')
> pkt = Packet(pkt_type=pkt_type.upper())
> for layer in pkt_layers.keys():
> pkt.config_layer(layer, pkt_layers[layer])
> - pkt.pktgen.write_pcap(savePath)
> + pkt.save_pcapfile(filename=savePath)
> streams.append(pkt.pktgen.pkt)
>
> return streams
> @@ -228,14 +228,14 @@ class PmdBonding(object):
> streams = []
> for values in pkt_configs:
> # keep a copy of pcap for debug
> - savePath = os.sep.join([self.target_source,
> + savePath = os.sep.join([TMP_PATH,
> "pkt_{0}.pcap".format(stm_name)])
> pkt_type = values.get('type')
> pkt_layers = values.get('pkt_layers')
> pkt = Packet(pkt_type=pkt_type.upper())
> for layer in pkt_layers.keys():
> pkt.config_layer(layer, pkt_layers[layer])
> - pkt.pktgen.write_pcap(savePath)
> + pkt.save_pcapfile(filename=savePath)
> streams.append(pkt.pktgen.pkt)
>
> return streams
> --
> 1.8.3.1
prev parent reply other threads:[~2019-10-22 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 7:29 Xiao Qimai
2019-10-17 8:08 ` Zhu, ShuaiX
2019-10-22 9:11 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB44F46@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=qimaix.xiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).