test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet	should has flags S
Date: Wed, 23 Oct 2019 09:40:07 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB45984@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1571377029-155913-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Friday, October 18, 2019 1:37 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet
> should has flags S
> 
> add flags S to SYN tcp packet and remove Raw from it
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_queue_region.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_queue_region.py
> b/tests/TestSuite_queue_region.py index eea873e..7d01dfb 100644
> --- a/tests/TestSuite_queue_region.py
> +++ b/tests/TestSuite_queue_region.py
> @@ -122,6 +122,8 @@ class TestQueue_region(TestCase):
>              pkt = Packet(pkt_type='TCP')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>              pkt.config_layer('tcp', {'flags': flags})
> +            if flags == 'S':
> +                pkt.pktgen.pkt.__delitem__('Raw')
>          elif (pkt_type == "sctp"):
>              pkt = Packet(pkt_type='SCTP')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac}) @@ -135,6
> +137,9 @@ class TestQueue_region(TestCase):
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>          elif (pkt_type == "ipv6_tcp"):
>              pkt = Packet(pkt_type='IPv6_TCP')
> +            pkt.config_layer('tcp',{'flags':flags})
> +            if flags == 'S':
> +                pkt.pktgen.pkt.__delitem__('Raw')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>          elif (pkt_type == "ipv6_sctp"):
>              pkt = Packet(pkt_type='IPv6_SCTP') @@ -262,7 +267,7 @@ class
> TestQueue_region(TestCase):
>          # not assign ipv4-tcp SYN packet to any queue region, the packet to
> queue region 0.
>          if(self.nic in ["fortpark_TLV"]):
>              queue_region = ["1"]
> -            queue_ipv6tcp = self.send_and_check(queue_region,
> mac=self.pf_mac, pkt_type="ipv6_tcp")
> +            queue_ipv6tcp = self.send_and_check(queue_region,
> + mac=self.pf_mac, pkt_type="ipv6_tcp", flags="S")
>          else:
>              queue_region = ["8", "9"]
>              queue_ipv6tcp = self.send_and_check(queue_region,
> mac=self.pf_mac, pkt_type="ipv6_tcp")
> --
> 1.8.3.1


      parent reply	other threads:[~2019-10-23  9:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  5:37 Xiao Qimai
2019-10-18  5:47 ` Zhu, WenhuiX
2019-10-23  9:40 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB45984@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).