Re: [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd

["Tu, Lijuan" <lijuan.tu@intel.com>]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Friday, October 25, 2019 11:07 AM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code
> to exit testpmd
> 
> Optimize the code to exit testpmd.
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_vf_jumboframe.py | 20 +++-----------------
>  1 file changed, 3 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_jumboframe.py
> b/tests/TestSuite_vf_jumboframe.py
> index dd728d9..f88f914 100644
> --- a/tests/TestSuite_vf_jumboframe.py
> +++ b/tests/TestSuite_vf_jumboframe.py
> @@ -174,7 +174,7 @@ class TestVfJumboFrame(TestCase):
> 
>          pkt = Packet(pkt_type='UDP', pkt_len=pktsize)
>          pkt.config_layer('ether', {'dst': mac})
> -        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
> +        pkt.send_pkt(self.tester, tx_port=self.tester_intf, timeout=30)
> 
>          time.sleep(1)
> 
> @@ -219,9 +219,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_normal_withjumbo(self):
>          """
>          When jumbo frame supported, this case is to verify that the normal size
> @@ -240,9 +237,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_nojumbo(self):
>          """
>          This case aims to test transmitting jumbo frame packet on testpmd
> without @@ -269,9 +263,6 @@ class TestVfJumboFrame(TestCase):
>          else:
>              self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_withjumbo(self):
>          """
>          When jumbo frame supported, this case is to verify that jumbo frame
> @@ -291,9 +282,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU - 1)
>          self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_overjumbo(self):
>          """
>          When the jubmo frame MTU set as 9000, this case is to verify that the
> @@ -315,14 +303,12 @@ class TestVfJumboFrame(TestCase):
>          else:
>              self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU + 1,
> False)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def tear_down(self):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.vm_testpmd.execute_cmd("stop")
> +        self.vm_testpmd.quit()
> 
>      def tear_down_all(self):
>          """
> --
> 2.17.2