test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:modify bug and increase	compatibility
Date: Tue, 5 Nov 2019 02:00:25 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB5DD35@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191029135733.17469-1-xiaoxiaox.zeng@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Tuesday, October 29, 2019 9:58 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:modify bug and increase
> compatibility
> 
> *.change -b to -w.
> *.modify verify to suit more scenes.
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_sriov_kvm.py | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index 51fdf68..546b01c 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -314,8 +314,7 @@ class TestSriovKvm(TestCase):
>              if driver == 'igb_uio':
>                  # start testpmd with the two VFs on the host
>                  self.host_testpmd = PmdOutput(self.dut)
> -                eal_param = '-b %(vf0)s -b %(vf1)s' % {'vf0':
> self.sriov_vfs_port[0].pci,
> -                                                       'vf1': self.sriov_vfs_port[1].pci}
> +                eal_param = '-w %s ' % self.dut.ports_info[0]['pci']
>                  self.host_testpmd.start_testpmd(
>                      "1S/2C/2T", "--rxq=4 --txq=4", eal_param=eal_param)
>                  self.host_testpmd.execute_cmd('set fwd rxonly') @@ -638,7 +637,7
> @@ class TestSriovKvm(TestCase):
>          # verify vm1 receive packets
>          vm1_ret_stats = self.calculate_stats(vm1_start_stats, vm1_end_stats)
> 
> -        self.verify(vm1_ret_stats['RX-packets'] == packet_num and
> vm1_ret_stats['TX-packets'] == packet_num,
> +        self.verify(vm1_ret_stats['RX-packets'] >= packet_num and
> + vm1_ret_stats['TX-packets'] >= packet_num,
>                      "Uplink mirror failed between VM0 and VM1!")
> 
>      def test_two_vms_downlink_mirror(self):
> @@ -809,7 +808,7 @@ class TestSriovKvm(TestCase):
>          self.set_port_pool_mirror(port_id_0, '0x1 dst-pool 1 on')
>          self.set_port_downlink_mirror(port_id_0, 'dst-pool 1 on')
> 
> -        if self.nic.startswith('niantic'):
> +        if self.nic.startswith('niantic') or self.nic.startswith('sage'):
>              self.set_port_uplink_mirror(port_id_0, 'dst-pool 1 on')
> 
>              # get vm port stats
> @@ -857,7 +856,7 @@ class TestSriovKvm(TestCase):
>          vm1_ret_stats = self.calculate_stats(vm1_start_stats, vm1_end_stats)
> 
>          try:
> -            if self.nic.startswith('niantic'):
> +            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
>                  self.verify(vm0_ret_stats['RX-packets'] == packet_num and
> vm1_ret_stats['RX-packets'] == packet_num,
>                              "vlan mirror failed between VM0 and VM1")
>              else:
> @@ -886,8 +885,8 @@ class TestSriovKvm(TestCase):
>          # verify vm1 receive packets
>          vm0_ret_stats = self.calculate_stats(vm0_start_stats, vm0_end_stats)
>          vm1_ret_stats = self.calculate_stats(vm1_start_stats, vm1_end_stats)
> -        self.verify(vm0_ret_stats['RX-packets'] == packet_num and
> vm0_ret_stats['TX-packets'] == packet_num and
> -                    vm1_ret_stats['RX-packets'] == packet_num, "uplink mirror failed
> between VM0 and VM1")
> +        self.verify(vm0_ret_stats['RX-packets'] == packet_num and
> vm1_ret_stats['RX-packets'] == packet_num,
> +                    "uplink mirror failed between VM0 and VM1")
> 
>      def test_two_vms_add_multi_exact_mac_on_vf(self):
>          port_id_0 = 0
> --
> 2.17.0


      parent reply	other threads:[~2019-11-05  2:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 13:57 Xiaoxiao Zeng
2019-10-29  2:00 ` Zhang, YanX A
2019-11-05  2:00 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB5DD35@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiaoxiaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).