test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] CVL does not need exception handling.
@ 2019-10-30  7:33 Peng Zhihong
  2019-10-30  7:39 ` He, Zhiwei
  2019-11-22  2:51 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Peng Zhihong @ 2019-10-30  7:33 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

CVL does not need exception handling.

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_dual_vlan.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 9cb3879..cb9c19c 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -149,7 +149,7 @@ class TestDualVlan(TestCase):
         """
 
         for mode in modeName:
-            if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]:
+            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]:
                 # fortville NIC vlan filter can't close, if want close need remove rx_vlan
                 if mode == "filter":
                     if modeName[mode] == "off":
@@ -166,7 +166,7 @@ class TestDualVlan(TestCase):
 
         out = self.dut.send_expect("show port info %s" % dutRxPortId, "testpmd> ")
         for mode in modeName:
-            if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g","fortpark_TLV", "carlsville"]:
+            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g","fortpark_TLV", "carlsville"]:
                 # fortville NIC vlan filter can't close, if want close need remove rx_vlan
                 if mode == "filter":
                     if modeName[mode] == "off":
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] CVL does not need exception handling.
  2019-10-30  7:33 [dts] [PATCH V1] CVL does not need exception handling Peng Zhihong
@ 2019-10-30  7:39 ` He, Zhiwei
  2019-11-22  2:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: He, Zhiwei @ 2019-10-30  7:39 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Acked-by zhiwei  <zhiwei.he@intel.com>
Thanks!
zhiwei

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
Sent: Wednesday, October 30, 2019 3:33 PM
To: dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: [dts] [PATCH V1] CVL does not need exception handling.

CVL does not need exception handling.

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_dual_vlan.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index 9cb3879..cb9c19c 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -149,7 +149,7 @@ class TestDualVlan(TestCase):
         """
 
         for mode in modeName:
-            if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]:
+            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]:
                 # fortville NIC vlan filter can't close, if want close need remove rx_vlan
                 if mode == "filter":
                     if modeName[mode] == "off":
@@ -166,7 +166,7 @@ class TestDualVlan(TestCase):
 
         out = self.dut.send_expect("show port info %s" % dutRxPortId, "testpmd> ")
         for mode in modeName:
-            if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g","fortpark_TLV", "carlsville"]:
+            if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g","fortpark_TLV", "carlsville"]:
                 # fortville NIC vlan filter can't close, if want close need remove rx_vlan
                 if mode == "filter":
                     if modeName[mode] == "off":
--
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] CVL does not need exception handling.
  2019-10-30  7:33 [dts] [PATCH V1] CVL does not need exception handling Peng Zhihong
  2019-10-30  7:39 ` He, Zhiwei
@ 2019-11-22  2:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-22  2:51 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Wednesday, October 30, 2019 3:33 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] CVL does not need exception handling.
> 
> CVL does not need exception handling.
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_dual_vlan.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index
> 9cb3879..cb9c19c 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -149,7 +149,7 @@ class TestDualVlan(TestCase):
>          """
> 
>          for mode in modeName:
> -            if self.nic in ["columbiaville_25g", "columbiaville_100g",
> "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV", "carlsville"]:
> +            if self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]:
>                  # fortville NIC vlan filter can't close, if want close need remove
> rx_vlan
>                  if mode == "filter":
>                      if modeName[mode] == "off":
> @@ -166,7 +166,7 @@ class TestDualVlan(TestCase):
> 
>          out = self.dut.send_expect("show port info %s" % dutRxPortId,
> "testpmd> ")
>          for mode in modeName:
> -            if self.nic in ["columbiaville_25g", "columbiaville_100g",
> "fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g","fortpark_TLV", "carlsville"]:
> +            if self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortville_25g","fortpark_TLV", "carlsville"]:
>                  # fortville NIC vlan filter can't close, if want close need remove
> rx_vlan
>                  if mode == "filter":
>                      if modeName[mode] == "off":
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-22  2:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30  7:33 [dts] [PATCH V1] CVL does not need exception handling Peng Zhihong
2019-10-30  7:39 ` He, Zhiwei
2019-11-22  2:51 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).