test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Ma, LihongX" <lihongx.ma@intel.com>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/external_memory:modify expected feedback
Date: Fri, 22 Nov 2019 05:46:14 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB677AE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191105192303.4106-1-xiaoxiaox.zeng@intel.com>

Hi xiaoxiao, could you please rework your patch based on Lihong' s comment.
thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Wednesday, November 6, 2019 3:23 AM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/external_memory:modify expected feedback
> 
> *.change expected testpmd> to link state change event.
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_external_memory.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_external_memory.py
> b/tests/TestSuite_external_memory.py
> index 9a75427..bb6d51e 100644
> --- a/tests/TestSuite_external_memory.py
> +++ b/tests/TestSuite_external_memory.py
> @@ -92,7 +92,7 @@ class TestExternalMemory(TestCase):
>          self.insmod_modprobe(modename="igb_uio")
>          cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -
> i"%(self.target,self.coremask)
> 
> -        self.dut.send_expect(cmd,"testpmd>",60)
> +        self.dut.send_expect(cmd,"link state change event",60)
>          self.verifier_result()
> 
>      def test_IGB_UIO_xmemhuage(self):
> @@ -103,7 +103,7 @@ class TestExternalMemory(TestCase):
> 
>          cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -
> i"%(self.target,self.coremask)
> 
> -        self.dut.send_expect(cmd,"testpmd>",60)
> +        self.dut.send_expect(cmd,"link state change event",60)
>          self.verifier_result()
> 
>      def test_VFIO_PCI_xmem(self):
> @@ -113,7 +113,7 @@ class TestExternalMemory(TestCase):
>          self.insmod_modprobe(modename="vfio-pci")
> 
>          cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -
> i"%(self.target,self.coremask)
> -        self.dut.send_expect(cmd,"testpmd>",60)
> +        self.dut.send_expect(cmd,"link state change event",60)
> 
>          self.verifier_result()
> 
> @@ -123,7 +123,7 @@ class TestExternalMemory(TestCase):
>          """
>          self.insmod_modprobe(modename="vfio-pci")
>          cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -
> i"%(self.target,self.coremask)
> -        self.dut.send_expect(cmd,"testpmd>",60)
> +        self.dut.send_expect(cmd,"link state change event",60)
> 
>          self.verifier_result()
> 
> --
> 2.17.0


      parent reply	other threads:[~2019-11-22  5:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 19:23 Xiaoxiao Zeng
2019-11-06  1:15 ` Ma, LihongX
2019-11-22  5:46 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB677AE@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=xiaoxiaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).