test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mei, JianweiX" <jianweix.mei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Mei, JianweiX" <jianweix.mei@intel.com>
Subject: Re: [dts] [PATCH V2] framework/dut.py:correct the code defect.
Date: Fri, 22 Nov 2019 05:51:24 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB677D4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1572946023-264438-1-git-send-email-jianweix.mei@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
> Sent: Tuesday, November 5, 2019 5:27 PM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V2] framework/dut.py:correct the code defect.
> 
> code logic error and modify it.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  framework/dut.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py index 54ff28b..4d8874a
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -120,7 +120,7 @@ class Dut(Crb):
>          if config:
>              # deal with cores
>              if config.has_key('cores'):
> -                if config['cores'] == '' or config['cores'] == 'Default':
> +                if config['cores'] == '' or config['cores'].lower() == 'default':
>                      core_list = self.get_core_list(default_cores)
>                  elif type(config['cores']) == list:
>                      core_list = config['cores'] @@ -144,7 +144,7 @@ class Dut(Crb):
>                              port_option = config['port_options'][port]
>                              w_pci_list.append('-w %s,%s' %
> (self.ports_info[config['ports'].index(port)]['pci'], port_option))
>                          else:
> -                            w_pci_list = ['-w %s' % pci for pci in config['ports']]
> +                            w_pci_list.append('-w %s' %
> + self.ports_info[config['ports'].index(port)]['pci'])
>              w_pci_str = ' '.join(w_pci_list)
> 
>              # deal with black ports
> --
> 1.8.3.1


      reply	other threads:[~2019-11-22  5:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  9:27 Jianwei Mei
2019-11-22  5:51 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB677D4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jianweix.mei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).