From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3827EA04C1; Fri, 22 Nov 2019 06:51:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD3552C23; Fri, 22 Nov 2019 06:51:29 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1D9A12C08 for ; Fri, 22 Nov 2019 06:51:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 21:51:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="205386253" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 21 Nov 2019 21:51:27 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 21:51:27 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 21:51:26 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 13:51:24 +0800 From: "Tu, Lijuan" To: "Mei, JianweiX" , "dts@dpdk.org" CC: "Mei, JianweiX" Thread-Topic: [dts] [PATCH V2] framework/dut.py:correct the code defect. Thread-Index: AQHVk7tO4+KX0GEVbUa12I79L5j9t6eWyj5Q Date: Fri, 22 Nov 2019 05:51:24 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB677D4@SHSMSX101.ccr.corp.intel.com> References: <1572946023-264438-1-git-send-email-jianweix.mei@intel.com> In-Reply-To: <1572946023-264438-1-git-send-email-jianweix.mei@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWVmZTc2MDItZDM4ZS00ZTdiLWFkMTktNzQyMzlhYjVhNGYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT005cWlXR1lacTV1eXlhUlhIbnZvQ0l3TGtZZnhvakVRSkpLQ09Fd08zbmRvWFN1a0crY3FnVTNcL2hkdzVZMmoifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] framework/dut.py:correct the code defect. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei > Sent: Tuesday, November 5, 2019 5:27 PM > To: dts@dpdk.org > Cc: Mei, JianweiX > Subject: [dts] [PATCH V2] framework/dut.py:correct the code defect. >=20 > code logic error and modify it. >=20 > Signed-off-by: Jianwei Mei > --- > framework/dut.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/framework/dut.py b/framework/dut.py index 54ff28b..4d8874a > 100644 > --- a/framework/dut.py > +++ b/framework/dut.py > @@ -120,7 +120,7 @@ class Dut(Crb): > if config: > # deal with cores > if config.has_key('cores'): > - if config['cores'] =3D=3D '' or config['cores'] =3D=3D '= Default': > + if config['cores'] =3D=3D '' or config['cores'].lower() = =3D=3D 'default': > core_list =3D self.get_core_list(default_cores) > elif type(config['cores']) =3D=3D list: > core_list =3D config['cores'] @@ -144,7 +144,7 @@ cl= ass Dut(Crb): > port_option =3D config['port_options'][port] > w_pci_list.append('-w %s,%s' % > (self.ports_info[config['ports'].index(port)]['pci'], port_option)) > else: > - w_pci_list =3D ['-w %s' % pci for pci in con= fig['ports']] > + w_pci_list.append('-w %s' % > + self.ports_info[config['ports'].index(port)]['pci']) > w_pci_str =3D ' '.join(w_pci_list) >=20 > # deal with black ports > -- > 1.8.3.1