Re: [dts] [PATCH V1] tests/TestSuite_kernelpf_iavf.py:An abnormal exit needs to execute the same command as a normal exit.

["Tu, Lijuan" <lijuan.tu@intel.com>]

Tear_down will be executed whatever the case is successful or failure. Every case will start from set_up and end with tear_down.
So I don't think it's reasonable to have this patch.

Another sighting, it's better to get current "trust setting" before you change it, and then restore it after your testing.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Ma, LihongX
> Sent: Friday, November 8, 2019 1:12 PM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/TestSuite_kernelpf_iavf.py:An abnormal
> exit needs to execute the same command as a normal exit.
> 
> If like that, I think we should put more time to verify it.
> 
> -----Original Message-----
> From: Peng, ZhihongX
> Sent: Thursday, November 7, 2019 3:21 PM
> To: Ma, LihongX <lihongx.ma@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] tests/TestSuite_kernelpf_iavf.py:An abnormal
> exit needs to execute the same command as a normal exit.
> 
> This case is executed twice, because the case was executed once when it was
> successful, so the exception exit is executed once for consistency.
> 
> -----Original Message-----
> From: Ma, LihongX
> Sent: Thursday, November 7, 2019 3:11 PM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/TestSuite_kernelpf_iavf.py:An abnormal
> exit needs to execute the same command as a normal exit.
> 
> Hi, zhihong
> I saw the cmd ' self.dut.send_expect("ip link set dev %s vf 0 trust off" %
> self.host_intf, "# ")' have been execute in tear_down So I think you don't
> need execute it before every verify.
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Wednesday, November 6, 2019 3:55 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_kernelpf_iavf.py:An abnormal exit
> needs to execute the same command as a normal exit.
> 
> An abnormal exit needs to execute the same command as a normal exit.
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py
> b/tests/TestSuite_kernelpf_iavf.py
> index 668eb28..89c22d3 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -47,6 +47,7 @@ from pmd_output import PmdOutput  from settings
> import HEADER_SIZE  from packet import Packet  from utils import RED
> +from exception import VerifyFailure
> 
>  VM_CORES_MASK = 'all'
>  MAX_VLAN = 4095
> @@ -336,18 +337,27 @@ class TestKernelpfIavf(TestCase):
>          self.vm_testpmd.execute_cmd("start")
>          self.send_random_pkt(self.vf_mac, count=1)
>          out = self.vm_dut.get_session_output()
> -        self.verify(self.vf_mac in out, 'vf receive pkt fail with current mac')
> +        if self.vf_mac not in out:
> +            self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf,
> "# ")
> +            raise VerifyFailure('allmulti all off vf receive pkt fail
> + with current mac')
>          self.send_random_pkt(multicast_mac, count=1)
>          out = self.vm_dut.get_session_output()
> -        self.verify(multicast_mac not in out, 'vf receive pkt with multicast mac')
> +        if multicast_mac in out:
> +            self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf,
> "# ")
> +            raise VerifyFailure('allmulti all off vf receive pkt with
> + multicast mac')
> 
>          self.vm_testpmd.execute_cmd("set allmulti all on")
>          self.send_random_pkt(self.vf_mac, count=1)
>          out = self.vm_dut.get_session_output()
> -        self.verify(self.vf_mac in out, 'vf receive pkt fail with current mac')
> +        if self.vf_mac not in out:
> +            self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf,
> "# ")
> +            raise VerifyFailure('allmulti all on vf receive pkt fail
> + with current mac')
>          self.send_random_pkt(multicast_mac, count=1)
>          out = self.vm_dut.get_session_output()
> -        self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
> +        if multicast_mac not in out:
> +            self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf,
> "# ")
> +            raise VerifyFailure('allmulti all on vf receive pkt fail
> + with multicast mac')
> +
>          self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf,
> "# ")
> 
>      def test_vf_broadcast(self):
> --
> 2.17.1