test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]framework/pmd_output: fix regex to match	file_prefix argument
Date: Fri, 22 Nov 2019 06:26:41 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB6791B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1573797105-38656-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Friday, November 15, 2019 1:52 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]framework/pmd_output: fix regex to match
> file_prefix argument
> 
> testpmd can accept eal parameter file_prefix without equal mark
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/pmd_output.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py index
> 03183ce..762f335 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -110,7 +110,7 @@ class PmdOutput():
>          :return:
>          """
>          re_w_pci_str = '\s?-w\\s+.+?:.+?:.+?\\..+?[,.*=\d+]?\s|\s?-
> w\\s+.+?:.+?\\..+?[,.*=\d+]?\s'
> -        re_file_prefix_str = '--file-prefix=.+?\s'
> +        re_file_prefix_str = '--file-prefix[=\s+].+\s'
>          re_b_pci_str = '\s?-b\\s+.+?:.+?:.+?\\..+?[,.*=\d+]?\s|\s?-
> b\\s+.+?:.+?\\..+?[,.*=\d+]?\s'
>          eal_param = eal_param + ' '
>          # pci_str_list eg: ['-w   0000:1a:00.0 ', '-w 0000:1a:00.1,queue-num-per-
> vf=4 ', '-w 0000:aa:bb.1,queue-num-per-vf=4 ']
> @@ -139,8 +139,8 @@ class PmdOutput():
> 
>          file_prefix = ''
>          if file_prefix_str:
> -            tmp = file_prefix_str[0].split('=')
> -            file_prefix = tmp[1].strip()
> +            tmp = re.split('(=|\s+)', file_prefix_str[-1].strip())
> +            file_prefix = tmp[-1].strip()
> 
>          other_eal_str = re.sub(re_w_pci_str, '', eal_param)
>          other_eal_str = re.sub(re_b_pci_str, '', other_eal_str)
> --
> 2.17.1


      reply	other threads:[~2019-11-22  6:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  5:51 Xiao Qimai
2019-11-22  6:26 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB6791B@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).