From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G
Date: Fri, 22 Nov 2019 06:32:33 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB67958@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191120213438.6931-1-xiaoxiaox.zeng@intel.com>
Hi xiaoxiao,
It's not difficult to have regex to suit for both condition, could you please to optimize the regex, thanks
result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Thursday, November 21, 2019 5:35 AM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add
> judgment range to suit CVL 100G
>
> *.to suit CVL 100G.
>
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..f0a4eea 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -317,7 +317,7 @@ class TestShutdownApi(TestCase):
>
> out = self.tester.send_expect(
> "ethtool %s" %
> self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
> - if 'fortville_spirit' == self.nic:
> + if 'fortville_spirit' == self.nic or 'columbiaville_100g' == self.nic:
> result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
> else:
> result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
> --
> 2.17.0
prev parent reply other threads:[~2019-11-22 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 21:34 Xiaoxiao Zeng
2019-11-22 6:32 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB67958@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=xiaoxiaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).