* [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
@ 2019-11-25 3:17 Xiao Qimai
2019-11-26 5:17 ` Ma, LihongX
2019-11-27 9:17 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2019-11-25 3:17 UTC (permalink / raw)
To: dts; +Cc: Xiao Qimai
update parameter of start_testpmd
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
tests/TestSuite_shutdown_api.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..4404f8b 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -248,7 +248,7 @@ class TestShutdownApi(TestCase):
"""
testcorelist = self.dut.get_core_list("1S/8C/1T", socket=self.ports_socket)
- self.pmdout.start_testpmd(testcorelist, "--portmask=%s --port-topology=loop" % utils.create_mask([self.ports[0]]), socket=self.ports_socket)
+ self.pmdout.start_testpmd("1S/8C/1T", "--portmask=%s --port-topology=loop" % utils.create_mask([self.ports[0]]), socket=self.ports_socket)
self.dut.send_expect("set promisc all off", "testpmd>")
fwdcoremask = utils.create_mask(testcorelist[-3:])
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
2019-11-25 3:17 [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api Xiao Qimai
@ 2019-11-26 5:17 ` Ma, LihongX
2019-11-27 9:17 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Ma, LihongX @ 2019-11-26 5:17 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
Hi, Qimai
I think we should optimization the dut code instead of change the suite code.
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Monday, November 25, 2019 11:18 AM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
update parameter of start_testpmd
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
tests/TestSuite_shutdown_api.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..4404f8b 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -248,7 +248,7 @@ class TestShutdownApi(TestCase):
"""
testcorelist = self.dut.get_core_list("1S/8C/1T", socket=self.ports_socket)
- self.pmdout.start_testpmd(testcorelist, "--portmask=%s --port-topology=loop" % utils.create_mask([self.ports[0]]), socket=self.ports_socket)
+ self.pmdout.start_testpmd("1S/8C/1T", "--portmask=%s
+ --port-topology=loop" % utils.create_mask([self.ports[0]]),
+ socket=self.ports_socket)
self.dut.send_expect("set promisc all off", "testpmd>")
fwdcoremask = utils.create_mask(testcorelist[-3:])
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
2019-11-25 3:17 [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api Xiao Qimai
2019-11-26 5:17 ` Ma, LihongX
@ 2019-11-27 9:17 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-27 9:17 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
It's not necessary to change arguments, start_testpmd can accept core list as input.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Monday, November 25, 2019 11:18 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of
> new api
>
> update parameter of start_testpmd
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..4404f8b 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -248,7 +248,7 @@ class TestShutdownApi(TestCase):
> """
> testcorelist = self.dut.get_core_list("1S/8C/1T", socket=self.ports_socket)
>
> - self.pmdout.start_testpmd(testcorelist, "--portmask=%s --port-
> topology=loop" % utils.create_mask([self.ports[0]]), socket=self.ports_socket)
> + self.pmdout.start_testpmd("1S/8C/1T", "--portmask=%s
> + --port-topology=loop" % utils.create_mask([self.ports[0]]),
> + socket=self.ports_socket)
> self.dut.send_expect("set promisc all off", "testpmd>")
> fwdcoremask = utils.create_mask(testcorelist[-3:])
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-27 9:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 3:17 [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api Xiao Qimai
2019-11-26 5:17 ` Ma, LihongX
2019-11-27 9:17 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).