From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88A1AA04F0; Thu, 19 Dec 2019 08:56:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71F541BC25; Thu, 19 Dec 2019 08:56:29 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7B7451252 for ; Thu, 19 Dec 2019 08:56:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 23:56:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="218097079" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 18 Dec 2019 23:56:26 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 23:56:26 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 23:56:25 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.236]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 15:56:24 +0800 From: "Tu, Lijuan" To: "Peng, Yuan" , "dts@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dts] [PATCH]test_plans: remove --tx-offload from commandline Thread-Index: AQHVrj2j7mUBhYJLEEuwM8IYH+Bo7KfBJxiA Date: Thu, 19 Dec 2019 07:56:23 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB898D7@SHSMSX101.ccr.corp.intel.com> References: <1575861054-55288-1-git-send-email-yuan.peng@intel.com> In-Reply-To: <1575861054-55288-1-git-send-email-yuan.peng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY1NmUwNDItZDQ4NS00OTM1LWE0MTQtOGMwZWM0NmUzMGRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFYxY2pmVU16bmU1d3VCYitFOXRpTjN0RlBPRTZEU1lCWDRSUERneUdjeXdWekZHV1BHTVhDWmJWYlVxbmpMaCJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]test_plans: remove --tx-offload from commandline X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan > Sent: Monday, December 9, 2019 11:11 AM > To: dts@dpdk.org > Cc: Peng, Yuan > Subject: [dts] [PATCH]test_plans: remove --tx-offload from commandline >=20 > remove --tx-offloads from testpmd commandline in macsec_test_plan.rst >=20 > Signed-off-by: Peng Yuan >=20 > diff --git a/test_plans/macsec_for_ixgbe_test_plan.rst > b/test_plans/macsec_for_ixgbe_test_plan.rst > index 79b7d57..997f921 100644 > --- a/test_plans/macsec_for_ixgbe_test_plan.rst > +++ b/test_plans/macsec_for_ixgbe_test_plan.rst > @@ -151,7 +151,7 @@ Test Case 1: MACsec packets send and receive > 1. Start the testpmd of tx port:: >=20 > ./testpmd -c 0xf0 --socket-mem 1024,0 --file-prefix=3Dtx -w 0000:0= 7:00.0 \ > - -- -i --port-topology=3Dchained --tx-offloads=3D0x00002000 > + -- -i --port-topology=3Dchained >=20 > 2. Set MACsec offload on:: >=20 > @@ -352,10 +352,7 @@ Test Case 5: normal packet send and MACsec > receive Test Case 6: MACsec send and receive with wrong parameters > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > -1. Don't add "--tx-offloads=3D0x00002000" in the tx_port command line. > - The MACsec offload can't work. The tx packets are normal packets. > - > -2. Set different pn on rx and tx port, then start the data transfer. > +1. Set different pn on rx and tx port, then start the data transfer. >=20 > 1. Set the parameters as test case 1, start and stop the data transfer= . > Check the result, rx port can receive and decrypt the packets norma= lly. > @@ -368,7 +365,7 @@ Test Case 6: MACsec send and receive with wrong > parameters >=20 > out_pkts_encrypted =3D in_pkts_late + in_pkts_ok >=20 > -3. Set different keys on rx and tx port, then start the data transfer:: > +2. Set different keys on rx and tx port, then start the data transfer:: >=20 > the RX-packets=3D0, > in_octets_decrypted =3D=3D out_octets_encrypted, @@ -376,20 +373,2= 3 @@ > Test Case 6: MACsec send and receive with wrong parameters > in_pkts_ok=3D0, > rx_good_packets=3D0 >=20 > -4. Set different pi on rx and tx port, then start the data transfer:: > +3. Set different pi on rx and tx port, then start the data transfer:: >=20 > in_octets_decrypted =3D=3D out_octets_encrypted, > in_pkts_ok =3D 0, > in_pkts_nosci =3D=3D out_pkts_encrypted >=20 > -5. Set different an on rx and tx port, then start the data transfer:: > + note: pi only support changed on rx side, if change pi on tx side, > + it will be omitted. > + > +4. Set different an on rx and tx port, then start the data transfer:: >=20 > rx_good_packets=3D0, > in_octets_decrypted =3D=3D out_octets_encrypted, > in_pkts_notusingsa =3D=3D out_pkts_encrypted, > in_pkts_ok=3D0, >=20 > -6. Set different index on rx and tx port, then start the data transfer:: > +5. Set different index on rx and tx port, then start the data transfer:: >=20 > in_octets_decrypted =3D=3D out_octets_encrypted, > in_pkts_ok =3D=3D out_pkts_encrypted > @@ -404,7 +404,7 @@ Test Case 7: performance test of MACsec offload > packets > MACsec offload on, set fwd mac:: >=20 > ./testpmd -c 0xf --socket-mem 1024,0 -- -i \ > - --port-topology=3Dchained --tx-offloads=3D0x00002000 > + --port-topology=3Dchained > testpmd> set macsec offload 0 on encrypt on replay-protect on > testpmd> set fwd mac > testpmd> start > @@ -423,7 +423,7 @@ Test Case 7: performance test of MACsec offload > packets > Start two testpmd:: >=20 > ./testpmd -c 0xf --socket-mem 1024,0 --file-prefix=3Drx -w 0000:07= :00.1 \ > - -- -i --port-topology=3Dchained --tx-offloads=3D0x00002000 > + -- -i --port-topology=3Dchained >=20 > testpmd> set macsec offload 0 on encrypt on replay-protect on > testpmd> set macsec sc rx 0 00:00:00:00:00:01 0 @@ -433,7 +433,7 @= @ > Test Case 7: performance test of MACsec offload packets > testpmd> set fwd rxonly >=20 > ./testpmd -c 0xf0 --socket-mem 1024,0 --file-prefix=3Dtx -b 0000:0= 7:00.1 \ > - -- -i --port-topology=3Dchained --tx-offloads=3D0x00002000 > + -- -i --port-topology=3Dchained >=20 > testpmd> set macsec offload 1 on encrypt on replay-protect on > testpmd> set macsec sc rx 1 00:00:00:00:00:02 0 > -- > 2.17.1