* [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts
@ 2019-12-24 23:06 lihong
2019-12-25 9:06 ` Ma, LihongX
2019-12-27 8:01 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: lihong @ 2019-12-24 23:06 UTC (permalink / raw)
To: dts; +Cc: lihong
Signed-off-by: lihong <lihongx.ma@intel.com>
---
framework/tester.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/framework/tester.py b/framework/tester.py
index 5b4aff0..7b05832 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -808,7 +808,9 @@ class Tester(Crb):
if self.it_uses_external_generator():
if self.is_pktgen and self.pktgen:
self.pktgen.quit_generator()
- self.restore_trex_interfaces()
+ # only restore ports if start trex in dts
+ if 'start_trex' in self.pktgen.conf.keys():
+ self.restore_trex_interfaces()
self.pktgen = None
elif self.ixia_packet_gen:
self.ixia_packet_gen.close()
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts
2019-12-24 23:06 [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts lihong
@ 2019-12-25 9:06 ` Ma, LihongX
2019-12-27 8:01 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Ma, LihongX @ 2019-12-25 9:06 UTC (permalink / raw)
To: dts
Tested-by:ma,lihong<lihongx.ma@intel.com>
-----Original Message-----
From: Ma, LihongX
Sent: Wednesday, December 25, 2019 7:07 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts][PATCH V1] framework/tester: only restore ports if start trex in dts
Signed-off-by: lihong <lihongx.ma@intel.com>
---
framework/tester.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/framework/tester.py b/framework/tester.py index 5b4aff0..7b05832 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -808,7 +808,9 @@ class Tester(Crb):
if self.it_uses_external_generator():
if self.is_pktgen and self.pktgen:
self.pktgen.quit_generator()
- self.restore_trex_interfaces()
+ # only restore ports if start trex in dts
+ if 'start_trex' in self.pktgen.conf.keys():
+ self.restore_trex_interfaces()
self.pktgen = None
elif self.ixia_packet_gen:
self.ixia_packet_gen.close()
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts
2019-12-24 23:06 [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts lihong
2019-12-25 9:06 ` Ma, LihongX
@ 2019-12-27 8:01 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-12-27 8:01 UTC (permalink / raw)
To: Ma, LihongX, dts; +Cc: Ma, LihongX
applied
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Wednesday, December 25, 2019 7:07 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework/tester: only restore ports if start trex in
> dts
>
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
> framework/tester.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/framework/tester.py b/framework/tester.py index
> 5b4aff0..7b05832 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -808,7 +808,9 @@ class Tester(Crb):
> if self.it_uses_external_generator():
> if self.is_pktgen and self.pktgen:
> self.pktgen.quit_generator()
> - self.restore_trex_interfaces()
> + # only restore ports if start trex in dts
> + if 'start_trex' in self.pktgen.conf.keys():
> + self.restore_trex_interfaces()
> self.pktgen = None
> elif self.ixia_packet_gen:
> self.ixia_packet_gen.close()
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-27 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 23:06 [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts lihong
2019-12-25 9:06 ` Ma, LihongX
2019-12-27 8:01 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).