Re: [dts] [PATCH V1 1/3] add case to ip_pipeline

["Tu, Lijuan" <lijuan.tu@intel.com>]

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Wednesday, January 8, 2020 2:31 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1 1/3] add case to ip_pipeline
> 
> add test_perf_pipeline_with_traffic_management
> 
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>  tests/TestSuite_ip_pipeline.py | 60 ++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/tests/TestSuite_ip_pipeline.py b/tests/TestSuite_ip_pipeline.py
> index f05b5cd..7bdfc52 100644
> --- a/tests/TestSuite_ip_pipeline.py
> +++ b/tests/TestSuite_ip_pipeline.py
> @@ -61,6 +61,7 @@ from scapy.packet import bind_layers, Raw  from
> scapy.arch import get_if_hwaddr  from scapy.sendrecv import sniff  from
> scapy.sendrecv import sendp
> +from pktgen import PacketGeneratorHelper
> 
>  class TestIPPipeline(TestCase):
> 
> @@ -224,6 +225,15 @@ class TestIPPipeline(TestCase):
>          self.verify("Error" not in out, "Compilation error")
> 
>          self.param_flow_dir = self.get_flow_direction_param_of_tcpdump()
> +        # get dts output path
[Lijuan] why need to get dts output path, I didn't find any call?
> +        if self.logger.log_path.startswith(os.sep):
> +            self.output_path = self.logger.log_path
> +        else:
> +            cur_path = os.path.dirname(
> +                os.path.dirname(os.path.realpath(__file__)))
> +            self.output_path = os.sep.join([cur_path, self.logger.log_path])
> +        # create an instance to set stream field setting
> +        self.pktgen_helper = PacketGeneratorHelper()
> 
>      def set_up(self):
>          """
> @@ -231,6 +241,56 @@ class TestIPPipeline(TestCase):
>          """
>          pass
> 
> +    def set_fields(self):
> +        """
> +        set ip protocol field behavior
> +        """
> +        fields_config = {
> +            'ip': {
> +                'dst': {'range': 1, 'action': 'inc'}, }, }
> +        return fields_config
> +
> +    def copy_cli_files_to_dut(self):
> +        """
> +        Copy traffic_manager.cli from tester to DUT
> +        """
> +        src_file = r'./dep/traffic_manager.cli'
> +        dst = '/tmp'
> +        self.dut.session.copy_file_to(src_file, dst)
> +        self.dut.send_expect("cp %s/traffic_manager.cli
> + ./examples/ip_pipeline/examples/" % dst, "#", 30)
[Lijuan] Can we copy to " ./examples/ip_pipeline/examples/ " directly?
> +
> +    def test_perf_pipeline_with_traffic_management(self):
> +        """
> +        rss pipeline
> +        """
> +        self.copy_cli_files_to_dut()
> +        cmd = "sed -i -e
> 's/0000:07:00.0/%s/' ./examples/ip_pipeline/examples/traffic_manager.cli" %
> self.dut_p0_pci
> +        self.dut.send_expect(cmd, "# ", 20)
> +        IP_PIPELINE = "./examples/ip_pipeline/build/ip_pipeline"
> +        DUT_PORTS = " -w {0}".format(self.dut_p0_pci)
> +        SCRIPT_FILE = "./examples/ip_pipeline/examples/traffic_manager.cli"
> +        cmd = "{0} -c 0x3 -n 4 {1} -- -s {2}".format(IP_PIPELINE, DUT_PORTS,
> SCRIPT_FILE)
> +        out = self.dut.send_expect(cmd, "15.255.0.0", 60)
> +        self.verify("failed" not in out, "Create rule failed!")
> +        pcap = os.sep.join([self.output_path, "test.pcap"])
> +        dmac = self.dut.get_mac_address(self.dut_ports[0])
> +        pkts = 'Ether(dst="%s")/IP(src="192.168.0.2",dst="0.%s.0.0")'
> +        strandard_pps = 14880000 / 4096
[Lijuan] why is 14880000 / 4096, can I use a 40Gb NIC for testing ?
> +        for i in range(0, 15):
> +            flow = pkts % (dmac, i)
> +            self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap, flow))
> +            tgenInput = []
> +            port = self.tester.get_local_port(self.dut_ports[0])
> +            vm_config = self.set_fields()
> +            tgenInput.append([port, port, pcap])
> +            self.tester.scapy_execute()
> +            self.tester.pktgen.clear_streams()
> +            streams =
> self.pktgen_helper.prepare_stream_from_tginput(tgenInput, 100, vm_config,
> self.tester.pktgen)
> +            _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams)
> +            difference_value = pps - strandard_pps
> +            self.verify(-100 < difference_value < 100, "throughput validation
> failure")
> +        self.dut.send_expect("^C", "#", 20)
> +
>      def test_routing_pipeline(self):
>          """
>          routing pipeline
> --
> 2.17.2